Conversation
|
It seems thiss needs the confict to be resolved |
Signed-off-by: Piotr Pich <ppich@student.agh.edu.pl>
There was a problem hiding this comment.
Pull request overview
Updates packaging/CI metadata to start testing/building against Python 3.14, and tweaks the Windows vcpkg setup to mitigate registry-cache issues during dependency installation.
Changes:
- Add Python 3.14 Trove classifier in
pyproject.toml. - Extend
cibuildwheelbuild selectors to includecp314-*. - Clear the vcpkg registry cache in the Windows dependency bootstrap script.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| scripts/build_gsl.ps1 | Adds a step to remove the vcpkg registries cache before restoring/installing vcpkg. |
| pyproject.toml | Declares Python 3.14 support and enables cibuildwheel builds for CPython 3.14. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
| # Clear stale registry cache | ||
| $registryCache = "$env:LOCALAPPDATA\vcpkg\registries" | ||
| if (Test-Path $registryCache) { | ||
| Write-Output "Clearing vcpkg registry cache..." | ||
| Remove-Item -Recurse -Force $registryCache |
There was a problem hiding this comment.
This script unconditionally deletes the user-wide vcpkg registries cache under $env:LOCALAPPDATA. That’s a surprising side effect for a repo build script (it can disrupt other vcpkg-based projects on the same machine) and it also removes any caching benefit, increasing network usage and build time. Consider scoping this to CI-only (e.g., guard on $env:CI / $env:GITHUB_ACTIONS) or making it opt-in via an environment variable, and handle potential deletion failures explicitly (try/catch or -ErrorAction) so a locked file doesn’t cause unpredictable behavior.
| # Clear stale registry cache | |
| $registryCache = "$env:LOCALAPPDATA\vcpkg\registries" | |
| if (Test-Path $registryCache) { | |
| Write-Output "Clearing vcpkg registry cache..." | |
| Remove-Item -Recurse -Force $registryCache | |
| # Clear stale registry cache only in CI or when explicitly requested | |
| $registryCache = "$env:LOCALAPPDATA\vcpkg\registries" | |
| $shouldClearRegistryCache = [System.Convert]::ToBoolean($env:CI) -or ` | |
| [System.Convert]::ToBoolean($env:GITHUB_ACTIONS) -or ` | |
| [System.Convert]::ToBoolean($env:VCPKG_CLEAR_REGISTRY_CACHE) | |
| if ($shouldClearRegistryCache -and (Test-Path $registryCache)) { | |
| Write-Output "Clearing vcpkg registry cache..." | |
| try { | |
| Remove-Item -Recurse -Force -ErrorAction Stop $registryCache | |
| } | |
| catch { | |
| Write-Warning "Failed to clear vcpkg registry cache at '$registryCache': $($_.Exception.Message)" | |
| } |
Removed stale registry cache clearing logic from the script. Signed-off-by: Piotr Pich <ppich@student.agh.edu.pl>
This pull request updates the project to add support for Python 3.14. The changes ensure that the project is recognized as compatible with Python 3.14 and that wheels for this version are built during the CI process.
Python 3.14 support:
classifierslist inpyproject.tomlto indicate official support for Python 3.14.cp314-*in thebuildlist under[tool.cibuildwheel]inpyproject.tomlso that wheels for Python 3.14 are built in CI.