Skip to content

Testing 3.14 python compability#167

Merged
grzanka merged 6 commits intomasterfrom
PYTHON314COMP
Apr 17, 2026
Merged

Testing 3.14 python compability#167
grzanka merged 6 commits intomasterfrom
PYTHON314COMP

Conversation

@PiotrPich2024
Copy link
Copy Markdown
Contributor

@PiotrPich2024 PiotrPich2024 commented Feb 23, 2026

This pull request updates the project to add support for Python 3.14. The changes ensure that the project is recognized as compatible with Python 3.14 and that wheels for this version are built during the CI process.

Python 3.14 support:

  • Added "Programming Language :: Python :: 3.14" to the classifiers list in pyproject.toml to indicate official support for Python 3.14.
  • Included cp314-* in the build list under [tool.cibuildwheel] in pyproject.toml so that wheels for Python 3.14 are built in CI.

@grzanka
Copy link
Copy Markdown
Contributor

grzanka commented Mar 30, 2026

It seems thiss needs the confict to be resolved

Signed-off-by: Piotr Pich <ppich@student.agh.edu.pl>
@PiotrPich2024 PiotrPich2024 marked this pull request as ready for review April 4, 2026 19:06
@grzanka grzanka requested a review from Copilot April 7, 2026 08:24
Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Updates packaging/CI metadata to start testing/building against Python 3.14, and tweaks the Windows vcpkg setup to mitigate registry-cache issues during dependency installation.

Changes:

  • Add Python 3.14 Trove classifier in pyproject.toml.
  • Extend cibuildwheel build selectors to include cp314-*.
  • Clear the vcpkg registry cache in the Windows dependency bootstrap script.

Reviewed changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.

File Description
scripts/build_gsl.ps1 Adds a step to remove the vcpkg registries cache before restoring/installing vcpkg.
pyproject.toml Declares Python 3.14 support and enables cibuildwheel builds for CPython 3.14.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Comment thread scripts/build_gsl.ps1 Outdated
Comment on lines +9 to +13
# Clear stale registry cache
$registryCache = "$env:LOCALAPPDATA\vcpkg\registries"
if (Test-Path $registryCache) {
Write-Output "Clearing vcpkg registry cache..."
Remove-Item -Recurse -Force $registryCache
Copy link

Copilot AI Apr 7, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This script unconditionally deletes the user-wide vcpkg registries cache under $env:LOCALAPPDATA. That’s a surprising side effect for a repo build script (it can disrupt other vcpkg-based projects on the same machine) and it also removes any caching benefit, increasing network usage and build time. Consider scoping this to CI-only (e.g., guard on $env:CI / $env:GITHUB_ACTIONS) or making it opt-in via an environment variable, and handle potential deletion failures explicitly (try/catch or -ErrorAction) so a locked file doesn’t cause unpredictable behavior.

Suggested change
# Clear stale registry cache
$registryCache = "$env:LOCALAPPDATA\vcpkg\registries"
if (Test-Path $registryCache) {
Write-Output "Clearing vcpkg registry cache..."
Remove-Item -Recurse -Force $registryCache
# Clear stale registry cache only in CI or when explicitly requested
$registryCache = "$env:LOCALAPPDATA\vcpkg\registries"
$shouldClearRegistryCache = [System.Convert]::ToBoolean($env:CI) -or `
[System.Convert]::ToBoolean($env:GITHUB_ACTIONS) -or `
[System.Convert]::ToBoolean($env:VCPKG_CLEAR_REGISTRY_CACHE)
if ($shouldClearRegistryCache -and (Test-Path $registryCache)) {
Write-Output "Clearing vcpkg registry cache..."
try {
Remove-Item -Recurse -Force -ErrorAction Stop $registryCache
}
catch {
Write-Warning "Failed to clear vcpkg registry cache at '$registryCache': $($_.Exception.Message)"
}

Copilot uses AI. Check for mistakes.
Removed stale registry cache clearing logic from the script.

Signed-off-by: Piotr Pich <ppich@student.agh.edu.pl>
@grzanka grzanka added this pull request to the merge queue Apr 17, 2026
Merged via the queue into master with commit fb0d006 Apr 17, 2026
3 checks passed
@grzanka grzanka deleted the PYTHON314COMP branch April 17, 2026 05:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants