Increase Seac iostream timeout because of read-poll latency#56
Open
weppos wants to merge 1 commit intolibdivecomputer:masterfrom
Open
Increase Seac iostream timeout because of read-poll latency#56weppos wants to merge 1 commit intolibdivecomputer:masterfrom
weppos wants to merge 1 commit intolibdivecomputer:masterfrom
Conversation
SEAC Tablet over BLE (read-poll transport) shows slow and variable command/response timing during device_open and early packet exchange. This commit raises the SEAC timeout to 3000ms to reduce early false timeouts seen with shorter values.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
SEAC Tablet over BLE (read-poll transport) shows
slow and variable command/response timing during
device_open and early packet exchange.
This commit raises the SEAC timeout to 3000ms
to reduce early false timeouts seen with shorter
values.
Examples of round-trips from the official vendor app
(on MacOS) that are also reflected on the BLE interaction using this lib:
It's possible the latency is a limitation of the BLE implementation on Mac/iPhone devices.