Add type annotations, fix type errors, and add CI checks #128
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Nikratio
force-pushed
the
nikratio/push-wrpnylwxuvxw
branch
4 times, most recently
from
653a7bc to
3026b81
Compare
Nikratio
force-pushed
the
nikratio/push-wrpnylwxuvxw
branch
from
3026b81 to
205fbd6
Compare
The sys.path manipulation is no longer needed for running examples.
Change the definition of `FileNameT`, `ModeT`, `FlagT` and `XAttrNameT` to be type aliases instead of new types. Since Python itself treats filenames, permission bits and xattr names as native types, having pyfuse3 use custom types requires a lot of casting without doing much about type safety.-
Nikratio
force-pushed
the
nikratio/push-wrpnylwxuvxw
branch
from
205fbd6 to
b78d4c1
Compare
Nikratio
force-pushed
the
nikratio/push-wrpnylwxuvxw
branch
from
b78d4c1 to
92ba0ff
Compare
Nikratio
force-pushed
the
nikratio/push-wrpnylwxuvxw
branch
from
92ba0ff to
f7dc177
Compare
Contributor
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 21 out of 22 changed files in this pull request and generated 4 comments.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Nikratio
force-pushed
the
nikratio/push-wrpnylwxuvxw
branch
2 times, most recently
from
f173fd1 to
50576ec
Compare
Nikratio
force-pushed
the
nikratio/push-wrpnylwxuvxw
branch
from
50576ec to
0db155f
Compare
When running in CI, there are differences bigger than 1 second. Until we have figured this out, disable the comparison. See #57
Nikratio
force-pushed
the
nikratio/push-wrpnylwxuvxw
branch
from
a1a0bba to
6bcaed9
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.