Skip to content

Conversation

@Nikratio
Copy link
Contributor

@Nikratio Nikratio commented Jan 4, 2026

No description provided.

Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR adds comprehensive type annotations to test files and examples, improving code clarity and enabling better static type checking. The changes primarily add type hints to function parameters and return types, update import statements to include specific types from pyfuse3, and make some minor refactoring improvements.

Key changes:

  • Added type annotations to all major functions in test utilities and example filesystem implementations
  • Updated imports to explicitly import pyfuse3 types (EntryAttributes, FileHandleT, InodeT, RequestContext, etc.)
  • Refactored some code for better consistency with type annotations (e.g., umount function variable usage, waited initialization)

Reviewed changes

Copilot reviewed 9 out of 9 changed files in this pull request and generated 7 comments.

Show a summary per file
File Description
test/util.py Added Process type alias and type annotations to utility functions; refactored umount to access exitcode directly
test/test_rounding.py Updated imports to explicitly import EntryAttributes
test/test_fs.py Added type annotations to Fs class methods; updated getattr calls to pass ctx parameter
test/test_api.py Updated imports to explicitly import pyfuse3 types
test/pytest_checklogs.py Added type annotations to logging handler and utility functions
examples/tmpfs.py Added comprehensive type annotations to Operations class; replaced getattr call with direct database query in release method
examples/passthroughfs.py Added comprehensive type annotations; added type-aware handling for root path (str vs set); improved variable naming (name_str, target_str)
examples/hello_asyncio.py Added type annotations to TestFs class methods and utility functions
examples/hello.py Added type annotations to TestFs class methods and utility functions

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@Nikratio Nikratio force-pushed the nikratio/push-pxlnqrpnsxpn branch from e817e40 to d34dfbd Compare January 4, 2026 16:55
@Nikratio Nikratio merged commit d34dfbd into main Jan 4, 2026
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants