Conversation
There was a problem hiding this comment.
Cursor Bugbot has reviewed your changes and found 1 potential issue.
Bugbot Free Tier Details
Your team is on the Bugbot Free tier. On this plan, Bugbot will review limited PRs each billing cycle for each member of your team.
To receive Bugbot reviews on all of your PRs, visit the Cursor dashboard to activate Pro and start your 14-day free trial.
Autofix Details
Bugbot Autofix prepared a fix for the issue found in the latest run.
- ✅ Fixed: False "not batch" error after valid queue filtering
- Removed the post-filter batch-environment validation so valid queue filters with zero matching jobs now correctly return an empty result instead of raising a false non-batch error.
Or push these changes by commenting:
@cursor push ddf295dfc4
Preview (ddf295dfc4)
diff --git a/cloudos_cli/clos.py b/cloudos_cli/clos.py
--- a/cloudos_cli/clos.py
+++ b/cloudos_cli/clos.py
@@ -1249,16 +1249,6 @@
if use_pagination_mode and target_job_count != 'all' and isinstance(target_job_count, int) and target_job_count > 0:
all_jobs = all_jobs[:target_job_count]
- # --- Validate queue filtering (check if environment is batch) ---
- if filter_queue:
- # Check if any jobs actually are batch jobs (non-batch jobs won't have jobQueue)
- batch_jobs = [job for job in all_jobs if job.get("batch", {})]
- if not batch_jobs:
- # No batch jobs found - verify environment actually has batch capability
- # by checking if any batch jobs exist in workspace at all
- # Note: This is a best-effort check with the current page being fetched
- raise ValueError(f"The environment is not a batch environment so queues do not exist. Please remove the --filter-queue option.")
-
return {'jobs': all_jobs, 'pagination_metadata': last_pagination_metadata}
@staticmethodThis Bugbot Autofix run was free. To enable autofix for future PRs, go to the Cursor dashboard.
There was a problem hiding this comment.
Cursor Bugbot has reviewed your changes and found 1 potential issue.
Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, enable autofix in the Cursor dashboard.
|
You have run out of free Bugbot PR reviews for this billing cycle. This will reset on April 6. To receive reviews on all of your PRs, visit the Cursor dashboard to activate Pro and start your 14-day free trial. |
|
thanks @l-mansouri The only thing that is confusing is the pagination data at the bottom "Showing 10 of 2037 total jobs | Page 115 of 204", but there is no way to navigate through the pages. I propose to unify this as the other tables , where we have that info but we can navigate it with "n = next, p = prev, q = quit" I am tagging @dapineyro since is out of the scope of this task, to keep in mind for future tickets:
|



Overview
This PR implements a fix for filtering by queue in
cloudos job listJIRA
LP-105358
Changes
Acceptance Criteria
What was happening before the fix
What happens after the fix
AZURE
CANNOT BE TESTED IN AZURE AS AZURE DO NOT HAVE AWS QUEUE
Note
Medium Risk
Changes pagination/stop conditions in
get_job_listwhen--filter-queueis used, which can alter job listing results and request volume. Low blast radius but affects a frequently used CLI path and could surface edge-case pagination bugs.Overview
Fixes
cloudos job list --filter-queueso queue filtering happens during pagination rather than after a single fetched page, ensuring jobs are found even when early pages contain no matches.This refactors
get_job_listto resolve the queue name to an ID up front, apply the queue filter per page, and continue fetching additional pages in direct--page/--page-sizemode until enough filtered results are collected or the API is exhausted. Version is bumped to2.82.1and the changelog documents the fix.Written by Cursor Bugbot for commit e9f4b32. This will update automatically on new commits. Configure here.