Skip to content

fix reuse render op #700

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
jfboeve merged 6 commits into from
Jan 15, 2026
Merged

fix reuse render op #700

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
15aa94e
fix reuse render op
chiefcll Jan 12, 2026
6a0ee4a
fix bug in addQuad as addTexture reassigns curRenderOp
chiefcll Jan 13, 2026
b6a981d
update reuse to handle RTT better
chiefcll Jan 13, 2026
64be14f
add null checks for fbd
chiefcll Jan 14, 2026
0d60253
Merge branch 'main' into fix/renderOps
chiefcll Jan 14, 2026
52e1313
remove opt property checks
chiefcll Jan 14, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions src/core/renderers/webgl/WebGlRenderOp.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -63,7 +63,7 @@ export class WebGlRenderOp extends CoreRenderOp {
readonly clippingRect: RectWithValid;
readonly rtt: boolean;
readonly parentHasRenderTexture: boolean;
readonly framebufferDimensions?: Dimensions | null;
readonly framebufferDimensions: Dimensions | null;
readonly alpha: number;
readonly pixelRatio: number;
readonly time?: number | null;
Expand All @@ -80,7 +80,7 @@ export class WebGlRenderOp extends CoreRenderOp {
this.height = quad.height;
this.clippingRect = quad.clippingRect;
this.parentHasRenderTexture = quad.parentHasRenderTexture;
this.framebufferDimensions = quad.framebufferDimensions;
this.framebufferDimensions = quad.framebufferDimensions || null;
this.rtt = quad.rtt;
this.alpha = quad.alpha;
this.pixelRatio =
Expand Down
32 changes: 22 additions & 10 deletions src/core/renderers/webgl/WebGlRenderer.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -258,11 +258,9 @@ export class WebGlRenderer extends CoreRenderer {
const u = this.uiQuadBuffer;
let i = this.curBufferIdx;

let ro = this.curRenderOp!;
const reuse = this.reuseRenderOp(params) === false;
if (reuse) {
const reuse = this.reuseRenderOp(params);
if (reuse === false) {
this.newRenderOp(params, i);
ro = this.curRenderOp!;
}

let tx = params.texture!;
Expand Down Expand Up @@ -320,7 +318,7 @@ export class WebGlRenderer extends CoreRenderer {
f[i + 30] = 1;
f[i + 31] = 1;

ro.numQuads++;
this.curRenderOp!.numQuads++;
this.curBufferIdx = i + 32;
}

Expand Down Expand Up @@ -387,16 +385,30 @@ export class WebGlRenderer extends CoreRenderer {
return false;
}

// Force new render operation if rendering to texture
// @todo: This needs to be improved, render operations could also be reused
// for rendering to texture
// Force new render operation if rendering to texture is different
if (
params.parentHasRenderTexture !== undefined ||
params.rtt !== undefined
this.curRenderOp.parentHasRenderTexture !==
params.parentHasRenderTexture ||
this.curRenderOp.rtt !== params.rtt
) {
return false;
}

if (
params.parentHasRenderTexture === true &&
this.curRenderOp.framebufferDimensions !== null &&
params.framebufferDimensions !== null
) {
if (
this.curRenderOp.framebufferDimensions.w !==
params.framebufferDimensions.w ||
this.curRenderOp.framebufferDimensions.h !==
params.framebufferDimensions.h
) {
return false;
}
}

if (
this.curRenderOp.shader.shaderKey === 'default' &&
params.shader?.shaderKey === 'default'
Expand Down