Make address optional in open-channel command#170
Open
joostjager wants to merge 1 commit intolightningdevkit:mainfrom
Open
Make address optional in open-channel command#170joostjager wants to merge 1 commit intolightningdevkit:mainfrom
joostjager wants to merge 1 commit intolightningdevkit:mainfrom
Conversation
When already connected to a peer, requiring the address to open a channel is unnecessary. The address field is now optional in the OpenChannelRequest proto and the CLI accepts pubkey@address format (like connect-peer) or just the pubkey alone. When no address is provided, the server resolves it from the connected peer list. AI tools were used in preparing this commit.
|
I've assigned @benthecarman as a reviewer! |
Collaborator
|
duplicate of #159 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When already connected to a peer, requiring the address to open a channel is unnecessary. The address field is now optional in the OpenChannelRequest proto and the CLI accepts pubkey@address format (like connect-peer) or just the pubkey alone. When no address is provided, the server resolves it from the connected peer list.
AI tools were used in preparing this commit.