Add Tor support for outbound connections#177
Open
Anyitechs wants to merge 1 commit intolightningdevkit:mainfrom
Open
Add Tor support for outbound connections#177Anyitechs wants to merge 1 commit intolightningdevkit:mainfrom
Anyitechs wants to merge 1 commit intolightningdevkit:mainfrom
Conversation
|
👋 Thanks for assigning @benthecarman as a reviewer! |
benthecarman
requested changes
Mar 31, 2026
ldk-server/src/util/config.rs
Outdated
| client_trusts_lsp = true | ||
|
|
||
| [tor] | ||
| proxy_address = "vww6ybal4bd7szmgncyruucpgfkqahzddi37ktce36gpflljhvevubid.onion:9735" |
Collaborator
There was a problem hiding this comment.
Proxy address will look like 127.0.0.1:9050. Can we use that here and below?
Contributor
Author
There was a problem hiding this comment.
Thank you. I missed the part of the docs that says "The proxy address must not itself be an onion address."
ldk-server/src/main.rs
Outdated
|
|
||
| if let Some(tor_config) = config_file.tor_config { | ||
| let tor_config = ldk_node::config::TorConfig { proxy_address: tor_config.proxy_address }; | ||
| let _ = builder.set_tor_config(tor_config); |
Collaborator
There was a problem hiding this comment.
we need to handle this error
Anyitechs
force-pushed
the
add-TorSupport
branch
from
96855e9 to
9af1012
Compare
Contributor
Author
|
Addressed comments and rebased to fix conflicts. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This allows us to add Tor support for outbound connections via SOCKS as introduced in lightningdevkit/ldk-node#778.