Skip to content

Clamp unsafe next outbound HTLC limit #4610

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
joostjager wants to merge 1 commit into
base: main
Choose a base branch
from
+13 −8
Draft

Clamp unsafe next outbound HTLC limit #4610

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
21 changes: 13 additions & 8 deletions lightning/src/ln/channel.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6250,7 +6250,7 @@ impl<SP: SignerProvider> ChannelContext<SP> {
let dust_exposure_limiting_feerate =
self.get_dust_exposure_limiting_feerate(&fee_estimator, funding.get_channel_type());

let balances = self
let mut balances = self
.get_next_remote_commitment_stats(
funding,
htlc_candidate,
Expand All @@ -6261,11 +6261,14 @@ impl<SP: SignerProvider> ChannelContext<SP> {
)
.map(|(remote_stats, _)| remote_stats.available_balances)?;

#[cfg(debug_assertions)]
if balances.next_outbound_htlc_limit_msat >= balances.next_outbound_htlc_minimum_msat
&& balances.next_outbound_htlc_limit_msat != 0
{
let (remote_stats, _remote_htlcs) = self
let reserve_msat = funding
.counterparty_selected_channel_reserve_satoshis
.unwrap_or(0)
.saturating_mul(1000);
let can_add_max_htlc = self
.get_next_remote_commitment_stats(
funding,
Some(HTLCAmountDirection {
Expand All @@ -6280,11 +6283,13 @@ impl<SP: SignerProvider> ChannelContext<SP> {
self.feerate_per_kw,
dust_exposure_limiting_feerate,
)
.unwrap();
assert!(
remote_stats.commitment_stats.holder_balance_msat
>= funding.counterparty_selected_channel_reserve_satoshis.unwrap_or(0) * 1000
);
.map(|(remote_stats, _remote_htlcs)| {
remote_stats.commitment_stats.holder_balance_msat >= reserve_msat
})
.unwrap_or(false);
if !can_add_max_htlc {
balances.next_outbound_htlc_limit_msat = 0;
}
}

Ok(balances)
Expand Down
Loading