swapserverrpc: risk acceptance/rejection notifications#1135
Conversation
Summary of ChangesHello, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request expands the server-to-client notification system by introducing new messages related to static loop-in risk management. These changes allow the server to explicitly inform the client when it has accepted or rejected the confirmation risk for a static loop-in, enabling better coordination for off-chain swap payments. Highlights
🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console. Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for GitHub and other Google products, sign up here. Footnotes
|
There was a problem hiding this comment.
Code Review
This pull request updates the swapserverrpc protobuf definitions to include two new notification types: ServerStaticLoopInRiskAcceptedNotification and ServerStaticLoopInRiskRejectedNotification. These messages are integrated into the SubscribeNotificationsResponse oneof field, enabling the server to notify clients when confirmation risk for a static loop-in is accepted or rejected. I have no feedback to provide.
preparatory commits for #1104