Skip to content

swapserverrpc: risk acceptance/rejection notifications#1135

Merged
hieblmi merged 2 commits into
lightninglabs:masterfrom
hieblmi:risk-notif
May 5, 2026
Merged

swapserverrpc: risk acceptance/rejection notifications#1135
hieblmi merged 2 commits into
lightninglabs:masterfrom
hieblmi:risk-notif

Conversation

@hieblmi
Copy link
Copy Markdown
Collaborator

@hieblmi hieblmi commented May 5, 2026

preparatory commits for #1104

@gemini-code-assist
Copy link
Copy Markdown

Summary of Changes

Hello, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request expands the server-to-client notification system by introducing new messages related to static loop-in risk management. These changes allow the server to explicitly inform the client when it has accepted or rejected the confirmation risk for a static loop-in, enabling better coordination for off-chain swap payments.

Highlights

  • New RPC Notifications: Added two new notification types, ServerStaticLoopInRiskAcceptedNotification and ServerStaticLoopInRiskRejectedNotification, to the SubscribeNotificationsResponse RPC stream.
  • Protocol Update: Updated the server.proto definition and regenerated the corresponding Go protobuf code to include these new notification messages for handling static loop-in risk status.

🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console.

Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for GitHub and other Google products, sign up here.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

@hieblmi hieblmi requested review from bhandras, sputn1ck and starius May 5, 2026 09:38
Copy link
Copy Markdown

@gemini-code-assist gemini-code-assist Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request updates the swapserverrpc protobuf definitions to include two new notification types: ServerStaticLoopInRiskAcceptedNotification and ServerStaticLoopInRiskRejectedNotification. These messages are integrated into the SubscribeNotificationsResponse oneof field, enabling the server to notify clients when confirmation risk for a static loop-in is accepted or rejected. I have no feedback to provide.

@hieblmi hieblmi merged commit 6ea1c79 into lightninglabs:master May 5, 2026
25 of 27 checks passed
@hieblmi hieblmi deleted the risk-notif branch May 5, 2026 11:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants