Skip to content

LCORE-1728: Upstream transformers#1756

Draft
tisnik wants to merge 3 commits into
lightspeed-core:mainfrom
tisnik:upstream-transformers
Draft

LCORE-1728: Upstream transformers#1756
tisnik wants to merge 3 commits into
lightspeed-core:mainfrom
tisnik:upstream-transformers

Conversation

@tisnik
Copy link
Copy Markdown
Contributor

@tisnik tisnik commented May 18, 2026

Description

LCORE-1728: Upstream transformers

Type of change

  • Refactor
  • New feature
  • Bug fix
  • CVE fix
  • Optimization
  • Documentation Update
  • Configuration Update
  • Bump-up service version
  • Bump-up dependent library
  • Bump-up library or tool used for development (does not change the final image)
  • CI configuration change
  • Konflux configuration change
  • Unit tests improvement
  • Integration tests improvement
  • End to end tests improvement
  • Benchmarks improvement

Tools used to create PR

  • Assisted-by: N/A
  • Generated by: N/A

Related Tickets & Documents

  • Related Issue #LCORE-1728

Summary by CodeRabbit

  • Chores
    • Updated runtime/model libraries: upgraded transformers to 5.8.1 and huggingface-hub to 1.15.0, added hf-xet 1.5.0, and refreshed corresponding dependency hashes.
    • Adjusted build/prefetch configuration to remove the previous transformers entry and align package lists with the updated pinned set.

Review Change Stack

@coderabbitai
Copy link
Copy Markdown
Contributor

coderabbitai Bot commented May 18, 2026

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: ASSERTIVE

Plan: Pro

Run ID: fe553a90-b1c3-4981-8e43-e70300e12e8a

📥 Commits

Reviewing files that changed from the base of the PR and between d7c4987 and f8f8cc6.

📒 Files selected for processing (4)
  • .konflux/requirements.hashes.source.txt
  • .konflux/requirements.hashes.wheel.txt
  • .tekton/lightspeed-stack-pull-request.yaml
  • .tekton/lightspeed-stack-push.yaml
💤 Files with no reviewable changes (1)
  • .konflux/requirements.hashes.wheel.txt
📜 Recent review details
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (12)
  • GitHub Check: build-pr
  • GitHub Check: unit_tests (3.12)
  • GitHub Check: unit_tests (3.13)
  • GitHub Check: Pylinter
  • GitHub Check: E2E Tests for Lightspeed Evaluation job
  • GitHub Check: E2E: library mode / ci / group 1
  • GitHub Check: E2E: server mode / ci / group 1
  • GitHub Check: E2E: library mode / ci / group 3
  • GitHub Check: E2E: server mode / ci / group 3
  • GitHub Check: E2E: library mode / ci / group 2
  • GitHub Check: E2E: server mode / ci / group 2
  • GitHub Check: Konflux kflux-prd-rh02 / lightspeed-stack-on-pull-request
🔇 Additional comments (5)
.tekton/lightspeed-stack-pull-request.yaml (1)

61-61: LGTM!

.tekton/lightspeed-stack-push.yaml (1)

53-53: LGTM!

.konflux/requirements.hashes.source.txt (3)

520-522: Version 1.15.0 is compatible with the current stack.

This version is the latest on PyPI and satisfies the dependency constraints of transformers==5.8.1, which requires huggingface-hub>=1.5.0,<2.0. No compatibility issues identified.


1071-1073: This major version upgrade from 4.57.6 to 5.8.1 requires verification of breaking changes and dependent component compatibility.

Version 5.8.1 is the current latest release on PyPI. However, the jump from the 4.x line to 5.x is a major version bump that typically introduces breaking changes. Before merging, please verify:

  • Breaking changes introduced in transformers 5.x are understood and addressed in the code
  • All dependent components (e.g., langchain, ray, etc.) are compatible with transformers 5.8.1

494-519: Clarify why hf-xet==1.5.0 is being added to requirements.

While version 1.5.0 is correct and the package is from a trusted Hugging Face source, hf-xet is not listed as a dependency of transformers==5.8.1. If this package is being added for other project-specific reasons (such as enabling fast file transfers with the Hugging Face Hub), that context should be documented in the requirements file or commit message for maintainability.

			> Likely an incorrect or invalid review comment.

Walkthrough

Source pinned requirements were updated: transformers==5.8.1 and hf-xet==1.5.0 were added, huggingface-hub was bumped to 1.15.0, corresponding wheel-hash entries for older packages were removed, the transformers override line changed, and Tekton prefetch lists had transformers removed.

Changes

Dependency pins and build configuration

Layer / File(s) Summary
Source requirements and overrides update
.konflux/requirements.hashes.source.txt, .konflux/requirements.overrides.txt
Added transformers==5.8.1 with hashes, added hf-xet==1.5.0 with hashes, and replaced huggingface-hub==0.36.2 with huggingface-hub==1.15.0; updated the transformers override line.
Wheel-hashes removal of old entries
.konflux/requirements.hashes.wheel.txt
Removed hf-xet and removed the old transformers==4.57.6 entries from the wheel-hashes file.
Tekton prefetch configuration update
.tekton/lightspeed-stack-pull-request.yaml, .tekton/lightspeed-stack-push.yaml
Removed transformers from the binary.packages pip prefetch lists in both pipeline manifests.

Estimated code review effort

🎯 3 (Moderate) | ⏱️ ~20 minutes

Possibly related issues

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title 'LCORE-1728: Upstream transformers' directly aligns with the main changeset objective: upstreaming the transformers package to a newer version while updating related dependencies.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
✨ Simplify code
  • Create PR with simplified code

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@tisnik tisnik marked this pull request as draft May 18, 2026 14:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant