-
Notifications
You must be signed in to change notification settings - Fork 63
fix: use sqlalchemy[asyncio] to ensure greenlet on all platforms #998
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
fix: use sqlalchemy[asyncio] to ensure greenlet on all platforms #998
Conversation
|
Hi @shanemcd. Thanks for your PR. I'm waiting for a lightspeed-core member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
WalkthroughThe project's SQLAlchemy dependency in Changes
Estimated code review effort🎯 1 (Trivial) | ⏱️ ~2 minutes 🚥 Pre-merge checks | ✅ 3✅ Passed checks (3 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. 📜 Recent review detailsConfiguration used: Path: .coderabbit.yaml Review profile: CHILL Plan: Pro 📒 Files selected for processing (1)
🧰 Additional context used📓 Path-based instructions (1)pyproject.toml📄 CodeRabbit inference engine (CLAUDE.md)
Files:
🔇 Additional comments (1)
✏️ Tip: You can disable this entire section by setting Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
SQLAlchemy's base dependencies specify greenlet with platform markers that exclude s390x. Since we use async SQLAlchemy features (via llama-stack), we need greenlet at runtime on all platforms. The [asyncio] extra includes greenlet unconditionally, fixing s390x builds that were failing with "No module named 'greenlet'". Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
4317ae8 to
a1917cc
Compare
|
@shanemcd you would need to regenerate lockfile and requirements files as well:
and
Btw is it really possible to run Llama-Stack on s390 platform? It depends on Pytorch and other "strange" libs... ;) |
Description
Use
sqlalchemy[asyncio]>=2.0.42instead ofsqlalchemy>=2.0.42to ensure greenlet is installed on all platforms.SQLAlchemy's base dependencies specify greenlet with platform markers that exclude s390x. Since we use async SQLAlchemy features (via llama-stack), we need greenlet at runtime on all platforms.
The
[asyncio]extra includes greenlet unconditionally, fixing s390x builds that were failing with "No module named 'greenlet'".Type of change
Tools used to create PR
Related Tickets & Documents
Checklist before requesting a review
Testing
Summary by CodeRabbit
✏️ Tip: You can customize this high-level summary in your review settings.