refs #121: Detect and linkify URLs in chatroom messages (doesn't work)#129
Open
mattj256 wants to merge 1 commit intolightvector:masterfrom
mattj256:iss121
Open
refs #121: Detect and linkify URLs in chatroom messages (doesn't work)#129mattj256 wants to merge 1 commit intolightvector:masterfrom mattj256:iss121
mattj256 wants to merge 1 commit intolightvector:masterfrom
mattj256:iss121
Conversation
Owner
|
Hehe, I also think it's easy. But this is the not the easy way to do it, because React auto-escapes text to protect against injection vulnerabilities and such when displaying dynamic content, and you shouldn't generally attempt to work around it. Instead, see components/gameroom.js for an example working usage of the "react-linkify" module. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I thought this would be easy...
What do I do now? Either this needs to be not HTML-escaped or I need some help getting this to play nicely with the React framework..
Here's a screenshot: