Shift the image factory code to work with the output parameter #395
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closed
Member
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The code for handling an image factory and the various drawers doesn't work unless the output is sent to stdout. This slightly shifts ordering of processing, to ensure that when outputting to a file, the various command line options and flags are taken into consideration.
I don't know if I was missing some reason that the
outputparameter always skipped all other options, but it was quite confusing, so I looked into it and it seemed like this mechanism could work? It should have minimal impact on the ascii output, but it does now require that the ascii flag is specified and will always output ascii if it is. Hopefully that's ok...