fix: Handle null user in comment transformation#38
Closed
rbolkey wants to merge 1 commit intolinearis-oss:mainfrom
Closed
fix: Handle null user in comment transformation#38rbolkey wants to merge 1 commit intolinearis-oss:mainfrom
rbolkey wants to merge 1 commit intolinearis-oss:mainfrom
Conversation
System-generated comments (e.g., Jira sync notifications) have user: null in the Linear API response. Apply the same null-checking pattern used for other nullable relationships (assignee, project, cycle). Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
Author
|
Ah, I see this is a duplicate of #35 |
phinze
added a commit
to phinze/nix-config
that referenced
this pull request
Mar 9, 2026
Fixes crash when Linear comments have a null user field (deleted users, integrations). Upstream fix: linearis-oss/linearis#38 — remove patch once released.
Collaborator
|
Thanks for the fix, @rbolkey! The codebase has been completely rewritten since this PR was opened (see #49), so this patch no longer applies. The comment handling code has been restructured. I'll verify whether the underlying bug (#6) still reproduces on the current version and handle it there. Closing this PR for now. Appreciate the contribution! 🙏 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
user: nullTest plan
npm test- all tests passnpm run build- compiles successfullynode dist/main.js issues read BRK-246- returns JSON without crashingResolves #6
🤖 Generated with Claude Code