Skip to content

refactor: standardize delete return types to {id, success}#86

Open
qorexdev wants to merge 1 commit intolinearis-oss:mainfrom
qorexdev:refactor/standardize-delete-return-types
Open

refactor: standardize delete return types to {id, success}#86
qorexdev wants to merge 1 commit intolinearis-oss:mainfrom
qorexdev:refactor/standardize-delete-return-types

Conversation

@qorexdev
Copy link
Copy Markdown
Contributor

@qorexdev qorexdev commented Apr 7, 2026

All delete* service functions now return { id: string; success: boolean } instead of boolean or void, matching the pattern from deleteComment.

  • deleteAttachment: returns { id: entityId, success: true } via GraphQL entityId
  • deleteDocument: returns { id, success: true } via GraphQL entity.id (fallback to input id)
  • deleteIssueRelation: returns { id: entityId, success: true } (already had entityId in query)
  • Updated documents delete command to pass the result directly to outputSuccess()
  • Updated tests for all three services

Closes #85

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

refactor: standardize delete return types across all domains

1 participant