Force ScriptImplementor to explicitly name columns in SELECT#191
Merged
Force ScriptImplementor to explicitly name columns in SELECT#191
Conversation
4eaaf27 to
1c42dc7
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
There is a regression in Flink 1.20, previously you could have two schemas where one is a subset of another. Take the following example:
Source Table:
Sink Table:
A flink SQL statement like the following would be valid (we would generate this prior to this PR):
In Flink 1.20 this throws an exception with: "Number of columns must match number of query columns".
The fix is to explicitly reference fields.
This PR changes the behavior to always explicitly name fields, even when a
SELECT *would be valid.