Conversation
Don't print, raise.
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #312 +/- ##
==========================================
- Coverage 62.92% 62.75% -0.18%
==========================================
Files 62 61 -1
Lines 8545 8521 -24
Branches 2437 2437
==========================================
- Hits 5377 5347 -30
- Misses 2557 2560 +3
- Partials 611 614 +3 ☔ View full report in Codecov by Sentry. |
|
The errors here are from comparisons being done to output files that don't exist - so the test is trivial, and the errors are correct, but should be conditioned on something like So we need to either:
The fact that the tests are failing on windows but the check appears to be passing in the gh interface indicates that the tests as currently configured don't actually alert us to failures (for windows). I assume that's from some weirdness in the way |
|
@sneakers-the-rat I have moved the work on this PR into the repo branch tests-fail . If you would like to continue this work please re-open the PR on the mono-repo after the merge from that branch. We'll lift it over for you so it should take less effort. This will have a slight rename in the linkml repo but you will be able to re-open it there. |
The output of the tests is pretty difficult to read, but there were lots of places that were saying "ERROR" without failing.
Looking further, it appears as if the default behavior for the TestEnvironment is to print, not fail on error.
There are also many print statements throughout the tests - raising an exception should be the print statement in tests.
This PR