Skip to content

feat: remove create charts from gitea and old scripts#325

Merged
j-zimnowoda merged 1 commit intomainfrom
APL-1462
Mar 12, 2026
Merged

feat: remove create charts from gitea and old scripts#325
j-zimnowoda merged 1 commit intomainfrom
APL-1462

Conversation

@ElderMatt
Copy link
Collaborator

This PR removes the creation of otomi/charts folder in gitea

@github-actions
Copy link

Coverage report

St.
Category Percentage Covered / Total
🔴 Statements
41.18% (+0.2% 🔼)
642/1559
🔴 Branches
29.86% (+0.23% 🔼)
152/509
🔴 Functions
26.81% (+0.11% 🔼)
63/235
🔴 Lines
42.07% (+0.19% 🔼)
605/1438

Test suite run success

54 tests passing in 6 suites.

Report generated by 🧪jest coverage report action from e7acbaf

Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR removes legacy support for creating/managing the otomi/charts repository in the Gitea operator and cleans up related constants and npm scripts, aligning the setup flow to only manage the otomi/values repo.

Changes:

  • Stop creating and team-assigning the otomi/charts repo during Gitea setup.
  • Remove the otomiChartsRepoName constant from the shared operator constants.
  • Remove tasks:otomi-chart* npm scripts from package.json.

Reviewed changes

Copilot reviewed 3 out of 3 changed files in this pull request and generated 1 comment.

File Description
src/operators/gitea/gitea.ts Removes otomi/charts repo creation and viewer-team assignment logic from Gitea setup.
src/operators/common.ts Drops the exported otomiChartsRepoName constant.
package.json Removes legacy tasks:otomi-chart scripts.
Comments suppressed due to low confidence (1)

src/operators/gitea/gitea.ts:697

  • The logic for assigning the otomi/values repo to the viewer team only runs when the repo was not found in existingRepos. If the repo already exists but is missing the otomi-viewer team assignment (e.g., it was removed manually), this function will not re-add it. Consider passing teamNameViewer into upsertRepo(...) (so it can repoCheckTeam/repoAddTeam) or otherwise ensure the team assignment is enforced regardless of prior repo existence.
  const existingValuesRepo = existingRepos.find((repo) => repo.name === otomiValuesRepoName)
  if (!existingValuesRepo) {
    try {
      console.info(`Adding repo "${otomiValuesRepoName}" to team "${teamNameViewer}"`)
      await repoApi.repoAddTeam({ owner: orgName, repo: otomiValuesRepoName, team: teamNameViewer })

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

You can also share your feedback on Copilot code review. Take the survey.

@j-zimnowoda j-zimnowoda merged commit 74c988d into main Mar 12, 2026
10 checks passed
@j-zimnowoda j-zimnowoda deleted the APL-1462 branch March 12, 2026 15:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants