feat: remove create charts from gitea and old scripts#325
Merged
j-zimnowoda merged 1 commit intomainfrom Mar 12, 2026
Merged
Conversation
Coverage report
Test suite run success54 tests passing in 6 suites. Report generated by 🧪jest coverage report action from e7acbaf |
There was a problem hiding this comment.
Pull request overview
This PR removes legacy support for creating/managing the otomi/charts repository in the Gitea operator and cleans up related constants and npm scripts, aligning the setup flow to only manage the otomi/values repo.
Changes:
- Stop creating and team-assigning the
otomi/chartsrepo during Gitea setup. - Remove the
otomiChartsRepoNameconstant from the shared operator constants. - Remove
tasks:otomi-chart*npm scripts frompackage.json.
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
src/operators/gitea/gitea.ts |
Removes otomi/charts repo creation and viewer-team assignment logic from Gitea setup. |
src/operators/common.ts |
Drops the exported otomiChartsRepoName constant. |
package.json |
Removes legacy tasks:otomi-chart scripts. |
Comments suppressed due to low confidence (1)
src/operators/gitea/gitea.ts:697
- The logic for assigning the
otomi/valuesrepo to the viewer team only runs when the repo was not found inexistingRepos. If the repo already exists but is missing theotomi-viewerteam assignment (e.g., it was removed manually), this function will not re-add it. Consider passingteamNameViewerintoupsertRepo(...)(so it canrepoCheckTeam/repoAddTeam) or otherwise ensure the team assignment is enforced regardless of prior repo existence.
const existingValuesRepo = existingRepos.find((repo) => repo.name === otomiValuesRepoName)
if (!existingValuesRepo) {
try {
console.info(`Adding repo "${otomiValuesRepoName}" to team "${teamNameViewer}"`)
await repoApi.repoAddTeam({ owner: orgName, repo: otomiValuesRepoName, team: teamNameViewer })
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
You can also share your feedback on Copilot code review. Take the survey.
ferruhcihan
approved these changes
Mar 12, 2026
j-zimnowoda
approved these changes
Mar 12, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR removes the creation of otomi/charts folder in gitea