Add FrontendVPCs support to NodeBalancers #857

komer3 · 2025-12-01T20:32:16Z

Add FrontendAddressType and FrontendVPCSubnetID fields to NodeBalancer struct
Add FrontendVPCs field to NodeBalancerCreateOptions struct
Add clarifying comment to IPv4RangeAutoAssign field in NodeBalancerVPCOptions

📝 Description

What does this PR do and why is this change necessary?

✔️ How to Test

What are the steps to reproduce the issue or verify the changes?

How do I run the relevant unit/integration tests?

📷 Preview

If applicable, include a screenshot or code snippet of this change. Otherwise, please remove this section.

- Add `FrontendAddressType` and `FrontendVPCSubnetID` fields to `NodeBalancer` struct - Add `FrontendVPCs` field to `NodeBalancerCreateOptions` struct - Add clarifying comment to `IPv4RangeAutoAssign` field in `NodeBalancerVPCOptions`

Copilot

Pull request overview

This PR adds support for frontend VPC configuration to NodeBalancers, enabling VPC-based frontend addressing alongside the existing backend VPC support. The changes introduce new fields to track frontend VPC subnet information and allow frontend VPC specification during NodeBalancer creation.

Key changes:

Added FrontendAddressType and FrontendVPCSubnetID fields to track frontend VPC configuration
Added FrontendVPCs option to enable frontend VPC specification during creation
Clarified that IPv4RangeAutoAssign applies only to backend VPC configuration

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

nodebalancer.go

zliang-akamai · 2026-01-10T06:44:32Z

nodebalancer.go

 	FrontendAddressType *string `json:"frontend_address_type,omitempty"`
 	// Frontend VPC subnet ID when using VPC addressing
 	FrontendVPCSubnetID *int `json:"frontend_vpc_subnet_id,omitempty"`


If they are not nullable, can we have them as non-pointer types?

errors.go

zliang-akamai · 2026-01-10T06:47:35Z

nodebalancer.go

 	SubnetID  int    `json:"subnet_id"`
 	// IPv4RangeAutoAssign is only used for backend VPC configuration.
 	// For frontend VPCs, this field is ignored.
 	IPv4RangeAutoAssign bool `json:"ipv4_range_auto_assign,omitempty"`


Couldn't find this attribute in the API spec doc. Is the doc outdated?

That field was part of backend VPC support for NB!

zliang-akamai · 2026-01-10T06:48:00Z

nodebalancer.go

 	IPv4Range string `json:"ipv4_range,omitempty"`
 	IPv6Range string `json:"ipv6_range,omitempty"`


If these fields are optional, can we have them as pointer types?

Yeah, makes sense to me!

Copilot

Pull request overview

Copilot reviewed 2 out of 2 changed files in this pull request and generated 3 comments.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Copilot · 2026-01-20T21:57:16Z

nodebalancer.go

 	IPv4 *string `json:"ipv4"`
 	// This NodeBalancer's public IPv6 address.
 	IPv6 *string `json:"ipv6"`
+	// Frontend address type (Either "vpc" or "public")


Comment should start with the field name for consistency with Go documentation conventions. Should be: 'FrontendAddressType is the frontend address type (either "vpc" or "public")'.

Suggested change

// Frontend address type (Either "vpc" or "public")

// FrontendAddressType is the frontend address type (either "vpc" or "public").

Copilot · 2026-01-20T21:57:16Z

nodebalancer.go

 	IPv6 *string `json:"ipv6"`
+	// Frontend address type (Either "vpc" or "public")
+	FrontendAddressType *string `json:"frontend_address_type,omitempty"`
+	// Frontend VPC subnet ID when using VPC addressing


Comment should start with the field name for consistency with Go documentation conventions. Should be: 'FrontendVPCSubnetID is the VPC subnet ID when using VPC addressing for the frontend'.

Suggested change

// Frontend VPC subnet ID when using VPC addressing

// FrontendVPCSubnetID is the VPC subnet ID when using VPC addressing for the frontend

Copilot · 2026-01-20T21:57:17Z

nodebalancer.go

+	IPv4Range *string `json:"ipv4_range,omitempty"`
+	IPv6Range *string `json:"ipv6_range,omitempty"`
+	SubnetID  int     `json:"subnet_id"`


Changing IPv4Range and IPv6Range from string to *string is a breaking API change that could affect existing users of this struct. Consider the impact on backwards compatibility.

Suggested change

IPv4Range *string `json:"ipv4_range,omitempty"`

IPv6Range *string `json:"ipv6_range,omitempty"`

SubnetID int `json:"subnet_id"`

IPv4Range string `json:"ipv4_range,omitempty"`

IPv6Range string `json:"ipv6_range,omitempty"`

SubnetID int `json:"subnet_id"`

Add FrontendVPCs support to NodeBalancer structs

852faf5

- Add `FrontendAddressType` and `FrontendVPCSubnetID` fields to `NodeBalancer` struct - Add `FrontendVPCs` field to `NodeBalancerCreateOptions` struct - Add clarifying comment to `IPv4RangeAutoAssign` field in `NodeBalancerVPCOptions`

komer3 marked this pull request as ready for review December 15, 2025 20:56

komer3 requested a review from a team as a code owner December 15, 2025 20:56

komer3 requested review from Copilot, yec-akamai and zliang-akamai and removed request for a team December 15, 2025 20:56

Copilot AI reviewed Dec 15, 2025

View reviewed changes

nodebalancer.go Outdated Show resolved Hide resolved

nodebalancer.go Show resolved Hide resolved

komer3 mentioned this pull request Dec 15, 2025

[feat] Add frontend VPC support for NodeBalancers linode/linode-cloud-controller-manager#501

Merged

10 tasks

Merge branch 'main' into nb-frontend-vpc

ba8bc59

AshleyDumaine reviewed Dec 16, 2025

View reviewed changes

nodebalancer.go Outdated Show resolved Hide resolved

AshleyDumaine reviewed Dec 16, 2025

View reviewed changes

nodebalancer.go Show resolved Hide resolved

AshleyDumaine reviewed Dec 16, 2025

View reviewed changes

nodebalancer.go Outdated Show resolved Hide resolved

AshleyDumaine reviewed Dec 16, 2025

View reviewed changes

nodebalancer.go Show resolved Hide resolved

komer3 and others added 3 commits January 8, 2026 16:14

Merge branch 'linode:main' into nb-frontend-vpc

e53356c

fix lint issue

d95d8e4

update comment

a9a67d6

yec-akamai changed the base branch from main to proj/frontend-vpcs January 9, 2026 19:38

zliang-akamai force-pushed the proj/frontend-vpcs branch from fb0a239 to 8a0a88c Compare January 10, 2026 06:27

zliang-akamai reviewed Jan 10, 2026

View reviewed changes

errors.go Show resolved Hide resolved

zliang-akamai reviewed Jan 10, 2026

View reviewed changes

Change NodeBalancerVPCOptions IPv4Range and IPv6Range fields to pointers

6cbd83f

zliang-akamai requested review from Copilot and zliang-akamai January 20, 2026 21:56

Copilot AI reviewed Jan 20, 2026

View reviewed changes

		IPv4Range string `json:"ipv4_range,omitempty"`
		IPv6Range string `json:"ipv6_range,omitempty"`

	// Frontend address type (Either "vpc" or "public")
	// FrontendAddressType is the frontend address type (either "vpc" or "public").

	// Frontend VPC subnet ID when using VPC addressing
	// FrontendVPCSubnetID is the VPC subnet ID when using VPC addressing for the frontend

Add FrontendVPCs support to NodeBalancers #857

Are you sure you want to change the base?

Add FrontendVPCs support to NodeBalancers #857

Uh oh!

Conversation

komer3 commented Dec 1, 2025

📝 Description

✔️ How to Test

📷 Preview

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

zliang-akamai Jan 10, 2026

Choose a reason for hiding this comment

Uh oh!

Uh oh!

zliang-akamai Jan 10, 2026

Choose a reason for hiding this comment

Uh oh!

komer3 Jan 12, 2026

Choose a reason for hiding this comment

Uh oh!

zliang-akamai Jan 10, 2026

Choose a reason for hiding this comment

Uh oh!

komer3 Jan 12, 2026

Choose a reason for hiding this comment

Uh oh!

komer3 Jan 12, 2026

Choose a reason for hiding this comment

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Uh oh!

Copilot AI Jan 20, 2026

Choose a reason for hiding this comment

Uh oh!

Copilot AI Jan 20, 2026

Choose a reason for hiding this comment

Uh oh!

Copilot AI Jan 20, 2026

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants