Release v1.134.0 - staging → master#11519
Merged
jaalah-akamai merged 113 commits intomasterfrom Jan 14, 2025
Merged
Conversation
* update hookform resolvers and try to fix schema issues * fix import * fix acl regression * revert linode create resolver change --------- Co-authored-by: Banks Nussman <banks@nussman.us>
…gacy flow (#11300) * fix: [M3-8912] - Create support ticket for bucket created through legacy flow * Added changeset: Create support ticket for buckets created through legacy flow
* test: [M3-8758]- Flake flaky test * Added changeset: Fix `delete-volume.spec.ts` flaky test
…11351) * Add aria-describedby to TextField with helper text * Always some ID * cleanup * add coverage * Added changeset: aria-describedby to TextField with helper text * cleanup * feedback @hkhalil-akamai
* nested JSON flags * fix overflow * Styling updates * save progress * save progress * Fix types * Wrapping up account customization * form improvements profile * cleanup * Added changeset: Dev Tools fixes and improvements * fix flake * feedback @jaalah-akamai
…4 type (#11369) * use query key factory * add changesets --------- Co-authored-by: Banks Nussman <banks@nussman.us>
Bumps [@eslint/plugin-kit](https://github.com/eslint/rewrite) from 0.2.0 to 0.2.4. - [Release notes](https://github.com/eslint/rewrite/releases) - [Changelog](https://github.com/eslint/rewrite/blob/main/release-please-config.json) - [Commits](eslint/rewrite@core-v0.2.0...plugin-kit-v0.2.4) --- updated-dependencies: - dependency-name: "@eslint/plugin-kit" dependency-type: indirect ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
* remove `reselect` dependency * add changeset * fix changeset message --------- Co-authored-by: Banks Nussman <banks@nussman.us>
* upcoming: [DI-20929] - Added labels parameter to global filter change handlers * upcoming: [DI-20929] - Added cloudpulse applied filter * upcoming: [DI-20929] - Added test cases * upcoming: [DI-20929] - updated failing test cases * upcoming: [DI-22221] - Fixed console error * upcoming: [DI-20929] - Added changeset * upcoming: [DI-20929] - Updated changeset * upcoming: [DI-20929] - Updated import libraries * upcomign: [DI-20929] - Updated types * upcomign: [DI-20929] - Updated types * upcoming: [DI-20929] - Updated styles for dark theme * upcoming: [DI-20929] - Updated styling * upcoming: [DI-20929 ] - Eslint issue fixed * upcoming: [DI-20929] - updated function order * upcoming: [DI-20929] - Improve code readability
* initial types * small fixes * support nodes * update validatoon schemas * add changesets * add comment * clean up types in manager * add changeset * clean up validation schemas * update and fix more nodebalancer schemas * make validation schema more strict * more improvements to schemas --------- Co-authored-by: Banks Nussman <banks@nussman.us>
* cypress test and small text changes * feat: dedicated LKE create cluster Cypress test for APL * fix: mocking apl feature flag * mock APL account beta * save progress * save prpgress on mocking all LKE creation * post rebase cleanup * Wrap up lke-create * cleanup * Added changeset: Mock LKE creation flow + APL coverage * feedback @bnussman-akamai @hkhalil-akamai * missing one mock * Added changeset: Nullable AccountBeta ended & description properties * damn you, APL * feedback @jdamore-linode * fix maybe flake * fix other flake --------- Co-authored-by: dennisvankekem <dvankeke@akamai.com>
* fix: [M3-8796] - Disallow word-break in billing contact info * Added changeset: Disallow word-break in billing contact info
…le and added relevant api endpoints (#11346) * upcoming: [DI-22217] - Added AlertListing component With Table headers, Table rows and added the GET api endpoint and mockServer for fetching alert definitions * upcoming : [DI-22217] - Added the TableRowError and TableRowLoading for the AlertListing Table and minor changes * upcoming: [DI-22217] - Added changesets * upcoming: [DI-22217] - Review changes: Improving AlertListing test cases, unabbreviated UT to Unit Tests in changeset * upcoming: [DI-22217] - Removed unused import * upcoming: [DI-22217] - Review changes: Removed redundant checks, removed waitFor in the unit tests and removed Severity column, removed the Placeholder Icon for Alerts Landing empty state * upcoming: [DI-22217] - Restructured the alert queries * upcoming: [DI-22217] - Review changes: Added a TableRowLabelMap for the TableHead Row, Replaced referencing colors directly and used theme styling for colors * upcoming: [DI-22217] - fixed eslint error * upcoming: [DI-22217] - Minor styling changes and fixed failing tests * upcoming: [DI-22217] - minor changes: changed the key when mapping over AlertListingTableLabelMap, used shorthand
* initial commit: wire new router * Migrate test to use new helper * volumes landing routing * doin the filtering * wire actions * cleanup * cleanup * moar cleanup * more work on params * usePaginationV2 * cleanup * oops fix types * fix e2e * useOrderV2 * and... dont forget the util 🤦 * revert unwarranted change * useOrderV2 test * console error * A bit more cleanup * usePaginationV2 test * usePaginationV2 test * route level error handling * xFilter util * xFilter util improvements * post rebase fix * testing xQuery builder * moar testing and cleanup * Added changeset: Migrate `/volumes` to Tanstack router * Save progress * fix one test * fix remaining test * feedback @jaalah-akamai * more work on preloading * save progress * Walking back and using a more progressive approach * cleanup * entity not found logic * post rebase fix * post rebase fix * update loading state * fix the smoke tests * Feedback @bnussman-akamai * JsDocs for Tanstack link components * Improve new useOrder hook * feedback @coliu-akamai @hkhalil-akamai
* fix: [M3-8538] - Fix Linode clone CLI Modal * remove comments * Fix cli command * Fix typos and unit tests and add missing slash in api url * Add changeset
…11367) * feat: [UIE-8136] - add new users table component (part 1) * Update changeset - file name must match changeset type --------- Co-authored-by: mjac0bs <mjacobs@akamai.com>
* Add e2e test for CC expired banner * Added changeset: Add cypress test for Credit Card Expired banner
…Backups.test.tsx` (#11394) * fix and clean up some tests * add changesets --------- Co-authored-by: Banks Nussman <banks@nussman.us>
* upcoming: [DI-20595] - ACLP Supported regions per service type * upcoming: [DI-20595] - small fix * upcoming: [DI-20595] - improved test quality * upcoming: [DI-20595] - PR Comments * upcoming: [DI-20595] - small fix * upcoming: [DI-20595] - updated UT * upcoming: [DI-20595] - updated UT * upcoming: [DI-20595] - updated types * upcoming: [DI-20595] - small linting fix * upcoming: [DI-20595] - handle empty regions * upcoming: [DI-20595] - Added changeset * upcoming: [DI-20595] - Added changeset * upcoming: [DI-20595] - edge case fix * upcoming: [DI-20595] - linting fix * Test[DI-20595] -add region select testcases * upcoming: [DI-20595] - PR Comments * upcoming: [DI-20595] - PR Comments * upcoming: [DI-20595] - linting fix Co-authored-by: Purvesh Makode <pmakode@akamai.com> * upcoming: [DI-20595] - linting fix Co-authored-by: Purvesh Makode <pmakode@akamai.com> * upcoming: [DI-20595] - linting fix Co-authored-by: Mariah Jacobs <114685994+mjac0bs@users.noreply.github.com> --------- Co-authored-by: agorthi <agorthi@akamai.com> Co-authored-by: Purvesh Makode <pmakode@akamai.com> Co-authored-by: Mariah Jacobs <114685994+mjac0bs@users.noreply.github.com>
…OS (#11253) * feat: [M3-8676] - Notice for OS Distro Nearing EOL/EOS * Added changeset: Notice for OS Distro Nearing EOL/EOS * operator change * formatted text and udpated state management * replaced new states with existing useImageQuery() * added decprecated notice for all ImageSelect references
…r on LKE-E versions (#11359) * Use the beta tiered versions query in the create flow * Set state for version options * Add tier to payload to create enterprise cluster * Add test coverage for tiered version selection * Fix linter warning * Added changeset: Update Kubernetes Versions in Create Cluster flow to support tiers for LKE-E * Make versions param optional - thanks @jdamore-linode Forgot to fix this after I was messing around with things Co-authored-by: jdamore-linode <97627410+jdamore-linode@users.noreply.github.com> * derive tiered versions from tier * version name refactoring * Use util for getting latest version in test specs * Remove loading state added * Revert 1313bd7 since mocking now; mock getVersions; use more recent latest versions --------- Co-authored-by: jdamore-linode <97627410+jdamore-linode@users.noreply.github.com> Co-authored-by: Hana Xu <hxu@akamai.com>
…11357) * begin refactoring VPC create hook * save * save progress * update tests for vpc components * update drawer * remove unnecessary types * fix vpc create drawer bug default values * general subnet errors? * remove unnecessary util * switch back to scrollIntoError v1 :/ * general subnet errors i think this works for real * Added changeset: Refactor VPC Create to use `react-hook-form` instead of `formik` * feedback @bnussman-akamai, fix reset when using cancel button for VPCCreateDrawer * cleanup use of useWatch and add some accessibility help to remove button * update cypress test due to updated accessibility labels for subnet remove buttons * hiding mention of IPv6 in validation for now since we don't support it * validation changeset
…wards (#11384) * fix: [M3-8971] - Object Storage object uploader spinner spinning backwards * Added changeset: Object Storage object uploader spinner spinning backwards * changed upload icon to autorenew * delete uploadPening.svg as it is not used anymore
…11398) * Fix misplaced `errorGroup` prop causing console error * Added changeset: Misplaced `errorGroup` prop causing console error in NodeBalancerConfigPanel
…tern (Part 1) (#11386) * initial refactor * fix type-safety issues * Update packages/manager/src/queries/profile/preferences.ts Co-authored-by: Purvesh Makode <pmakode@akamai.com> * fix re-render at maincontent level @mjac0bs * Update packages/manager/src/queries/profile/preferences.ts Co-authored-by: Mariah Jacobs <114685994+mjac0bs@users.noreply.github.com> --------- Co-authored-by: Banks Nussman <banks@nussman.us> Co-authored-by: Purvesh Makode <pmakode@akamai.com> Co-authored-by: Mariah Jacobs <114685994+mjac0bs@users.noreply.github.com>
…use `react-hook-form` (#11393) * update schema, update vpc edit drawer * update SubnetEditDrawer * changesets
…y when any pending updates are available and disable version upgrade (#11387)
…KE-E (#11413) * Clean up account beta endpoint and query * Fix test to mock no LKE-E capability when expected * Add changesets
* unit test coverage for HostNameTableCell * Revert "unit test coverage for HostNameTableCell" This reverts commit b274baf. * chore: [M3-8662] - Update Github Actions actions (#11009) * update actions * add changeset --------- Co-authored-by: Banks Nussman <banks@nussman.us> * Basci date picker component * Test coverage for date picker component * DatePicker Stories * Custom DateTimePicker component * Reusable TimeZone Select Component * Create custom DateTimeRangePicker component * Storybook for DateTimePicker * Fix tests and remove console warnings * changeset * Update packages/manager/src/components/DatePicker/DateTimeRangePicker.tsx Co-authored-by: Connie Liu <139280159+coliu-akamai@users.noreply.github.com> * Adjust styles for DatePicker * Adjust styles for DateTimePicker * update imports * Render time and timezone conditionally in DateTimePicker component * Move DatePicker to UI package * Add DatePicker dependencies * Code cleanup * PR feedback * code cleanup * Move DatePicker back to src/components * Reverting changes * Code cleanup * Adjust broken tests * Update TimeZoneSelect.tsx * Code cleanup * Add validation for start date agains end date. * Adjust styles for TimePicker component. * PR feedback - @jaalah-akamai * allow error messages from props. * Update storybook components with args * Update props * PR feedback - @hana-akamai --------- Co-authored-by: Banks Nussman <115251059+bnussman-akamai@users.noreply.github.com> Co-authored-by: Banks Nussman <banks@nussman.us> Co-authored-by: Connie Liu <139280159+coliu-akamai@users.noreply.github.com>
* change: [M3-9074] - Remove properties tab from Gen2 buckets * Added changeset: Temporarily remove Properties tab from Gen2 buckets --------- Co-authored-by: Jaalah Ramos <jaalah.ramos@gmail.com>
* upcoming: [M3-9008] Improve Close Account UI * Add changesets * Update e2e test to cover parent/child * More cleanup * Change warning to error and update variants/colors * Enforce type-to-confirm for close account * Small revert * Revision * Text updates to title, warning, comment blurb * Expand comments section full width - allow this prop to be set * Fix unit tests due to usePreference updates - remove loading variant * Update packages/manager/cypress/e2e/core/account/account-cancellation.spec.ts Co-authored-by: Connie Liu <139280159+coliu-akamai@users.noreply.github.com> * Update packages/manager/cypress/e2e/core/account/account-cancellation.spec.ts Co-authored-by: Connie Liu <139280159+coliu-akamai@users.noreply.github.com> * Update packages/manager/cypress/e2e/core/account/account-cancellation.spec.ts Co-authored-by: Connie Liu <139280159+coliu-akamai@users.noreply.github.com> * Update state variable name @coliu-akamai * Allow expand to be passed for deletionDialogs * Expand all delete type-to-confirms @coliu-akamai * more deletion dialogs * Few more dialogs --------- Co-authored-by: Jaalah Ramos <jaalah.ramos@gmail.com> Co-authored-by: Connie Liu <139280159+coliu-akamai@users.noreply.github.com>
…nent. (#11395) * unit test coverage for HostNameTableCell * Revert "unit test coverage for HostNameTableCell" This reverts commit b274baf. * chore: [M3-8662] - Update Github Actions actions (#11009) * update actions * add changeset --------- Co-authored-by: Banks Nussman <banks@nussman.us> * Basci date picker component * Test coverage for date picker component * DatePicker Stories * Custom DateTimePicker component * Reusable TimeZone Select Component * Create custom DateTimeRangePicker component * Storybook for DateTimePicker * Fix tests and remove console warnings * changeset * Update packages/manager/src/components/DatePicker/DateTimeRangePicker.tsx Co-authored-by: Connie Liu <139280159+coliu-akamai@users.noreply.github.com> * Adjust styles for DatePicker * Adjust styles for DateTimePicker * update imports * Render time and timezone conditionally in DateTimePicker component * Move DatePicker to UI package * Add DatePicker dependencies * Code cleanup * PR feedback * code cleanup * Move DatePicker back to src/components * Reverting changes * Code cleanup * Adjust broken tests * Update TimeZoneSelect.tsx * Code cleanup * Add validation for start date agains end date. * Adjust styles for TimePicker component. * Add the functionality to support Date Presets * Update presets functionality and add test coverage. * Added changeset: Add Date Presets Functionality to Date Picker component * Persist the preset value * Show the start date and end date fields only when custom is selected * Add calendar icon to DateTimePicker component * code cleanup and adjust tests * Update packages/manager/src/components/DatePicker/DateTimeRangePicker.tsx Co-authored-by: Nikhil Agrawal <165884194+nikhagra-akamai@users.noreply.github.com> * update components * Organize and additional prop support to DateTimeRangePicker component * Code cleanup * PR feedback - @coliu-akamai * Move styles to theme level * Revert "Move styles to theme level" This reverts commit 15d9134. * code cleanup --------- Co-authored-by: Banks Nussman <115251059+bnussman-akamai@users.noreply.github.com> Co-authored-by: Banks Nussman <banks@nussman.us> Co-authored-by: Connie Liu <139280159+coliu-akamai@users.noreply.github.com> Co-authored-by: Nikhil Agrawal <165884194+nikhagra-akamai@users.noreply.github.com>
…8.0, and UI version 0.5.0
* change: [UIE-8228] - Database Resize: disable same size plan * Added changeset: Database Resize: Disable plans when the usable storage equals the used storage of the database cluster
## Description 📝 This attempts to fix a unit test failure in `DateTimeRangePicker.test.ts` when the test is run in an environment whose system locale is not set to central time (UTC-06:00). Also does some clean up related to the way that the system time is mocked. ## Changes 🔄 - Fix test failure in DateTimeRangePicker unit tests - Clean up ## How to test 🧪 ```bash yarn test DateTimeRangePicker.test ```
…ton to be disabled (#11500) ## Description 📝 There is an edge case where `preferences?.type_to_confirm` is `undefined` when the user has not yet set a preference as seen in `/profile/settings?preferenceEditor=true`. ## Changes 🔄 - Ensure that `preferences?.type_to_confirm` resolves to a boolean value (default true) ## How to test 🧪 ### Prerequisites - Removed `type_to_confirm` preference from /profile/settings?preferenceEditor=true ### Reproduction steps - Observe the disabled button for linode deletion dialogs and others ### Verification steps #### Step 1 - Removed `type_to_confirm` preference from /profile/settings?preferenceEditor=true - Ensure type-to-confirm is enabled by default - Check linode: delete, resize, rebuild - Check domain: delete - Check close account still works as intended #### Step 2 - Disable type-to-confirm - Check linode: delete, resize, rebuild - Check domain: delete - Check close account still works as intended --------- Co-authored-by: Jaalah Ramos <jaalah.ramos@gmail.com> Co-authored-by: Hana Xu <hxu@akamai.com>
Release v1.134.0 - release → staging
jaalah-akamai
requested review from
dmcintyr-akamai,
dwiley-akamai and
hasyed-akamai
dwiley-akamai
approved these changes
Jan 14, 2025
cpathipa
approved these changes
Jan 14, 2025
Collaborator
Cloud Manager UI test results🔺 3 failing tests on test run #1 ↗︎
Details
TroubleshootingUse this command to re-run the failing tests: yarn cy:run -s "cypress/e2e/core/linodes/smoke-linode-landing-table.spec.ts,cypress/e2e/core/cloudpulse/cloudpulse-navigation.spec.ts,cypress/e2e/core/linodes/clone-linode.spec.ts" |
|||||||||||||||||||||||
coliu-akamai
approved these changes
Jan 14, 2025
jdamore-linode
approved these changes
Jan 14, 2025
Contributor
jdamore-linode
left a comment
jdamore-linode
left a comment
There was a problem hiding this comment.
Test failures can be disregarded:
- Clone failure is a result of typical flake in that test
- Smoke Linode landing and CloudPulse nav are both failing because the nav preferences for the test account got changed -- fixed that and confirmed those flows are passing
hana-akamai
approved these changes
Jan 14, 2025
mjac0bs
approved these changes
Jan 14, 2025
hkhalil-akamai
approved these changes
Jan 14, 2025
Cloud Manager E2E
|
||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
| Project |
Cloud Manager E2E
|
| Branch Review |
master
|
| Run status |
|
| Run duration | 32m 13s |
| Commit |
|
| Committer | Jaalah Ramos |
| View all properties for this run ↗︎ | |
| Test results | |
|---|---|
Failures
|
1
|
Flaky
|
5
|
Pending
|
2
|
Skipped
|
0
|
Passing
|
473
|
| View all changes introduced in this branch ↗︎ | |
Tests for review
cypress/e2e/core/volumes/update-volume.spec.ts • 1 failed test
| Test | Artifacts | |
|---|---|---|
| volume update flow > updates a volume's label |
Screenshots
Video
|
|
linodes/linode-config.spec.ts • 1 flaky test
| Test | Artifacts | |
|---|---|---|
| Linode Config management > End-to-End > Clones a config |
Screenshots
Video
|
|
volumes/update-volume.spec.ts • 1 flaky test
| Test | Artifacts | |
|---|---|---|
| volume update flow > updates volume's tags |
Screenshots
Video
|
|
volumes/delete-volume.spec.ts • 1 flaky test
| Test | Artifacts | |
|---|---|---|
| volume delete flow > deletes a volume |
Screenshots
Video
|
|
volumes/clone-volume.spec.ts • 1 flaky test
| Test | Artifacts | |
|---|---|---|
| volume clone flow > clones a volume |
Screenshots
Video
|
|
volumes/resize-volume.spec.ts • 1 flaky test
| Test | Artifacts | |
|---|---|---|
| volume resize flow > resizes a volume |
Screenshots
Video
|
|
4 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
20 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Added:
Changed:
Fixed:
errorGroupprop causing console error in NodeBalancerConfigPanel (#11398)RegionHelperTextcausing console errors (#11416)Create Tokenbutton becomes disabled when all permissions are selected individually (without using 'select all') and child-account is hidden (#11453)endpoint_typesorting (#11472)Removed:
Images are not encrypted warningwarning (#11443)Tech Stories:
/volumesto Tanstack router (#11154)react-hook-forminstead offormik(#11357)react-hook-forminstead offormik(#11393)IMAGE_REGISTRYDocker build argument (#11360)reselectdependency (#11364)useObjectAccessto use a query key factory (#11369)react-selectin Managed (#11391)cookieversion as resolution for dependabot (#11434)react-vncto 2.0.2 (#11467)Tests:
delete-volume.spec.tsflaky test (#11365)smoke-billing-activity.spec.ts(#11394)DatabaseBackups.test.tsx(#11394)Upcoming Features:
CloudPulseAppliedFilterandCloudPulseAppliedFilterRenderercomponents, update filter change handler function to add another parameterlabel(#11354)getFiltersutil method inFilterBuilder.ts(#11388)