-
Notifications
You must be signed in to change notification settings - Fork 398
upcoming: [M3-9495] - Disable APL for LKE-E clusters #11809
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. Weβll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
mjac0bs
merged 11 commits into
linode:develop
from
mjac0bs:M3-9495-disable-apl-for-lke-e
Mar 14, 2025
Merged
Changes from all commits
Commits
Show all changes
11 commits
Select commit
Hold shift + click to select a range
e5dff3b
Show the APL section only for standard cluster tiers
0cd2df1
Added changeset: Disable APL for LKE-E clusters on create flow
ebfb57b
WIP - poc for what disabled, rather than hidden, section would look like
98942b8
Merge branch 'develop' into M3-9495-disable-apl-for-lke-e
b0626b2
Update with proposed UX changes
4ec7024
Update test coverage with mocked endpoints, UX changes
1000956
Tweak changeset
1fd39f0
Merge branch 'develop' into M3-9495-disable-apl-for-lke-e
ad5823f
Merge branch 'develop' into M3-9495-disable-apl-for-lke-e
b5362b1
Update chip text size to small for consistency with other chips
cfe66c9
Fix bug preventing 'no' button from being checked
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
5 changes: 5 additions & 0 deletions
5
packages/manager/.changeset/pr-11809-upcoming-features-1741383768710.md
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,5 @@ | ||
| --- | ||
| "@linode/manager": Upcoming Features | ||
| --- | ||
|
|
||
| Disable Akamai App Plaform beta for LKE-E clusters on create flow ([#11809](https://github.com/linode/manager/pull/11809)) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
57 changes: 57 additions & 0 deletions
57
packages/manager/src/features/Kubernetes/CreateCluster/ApplicationPlatform.test.tsx
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,57 @@ | ||
| import userEvent from '@testing-library/user-event'; | ||
| import React from 'react'; | ||
|
|
||
| import { renderWithTheme } from 'src/utilities/testHelpers'; | ||
|
|
||
| import { ApplicationPlatform } from './ApplicationPlatform'; | ||
|
|
||
| const MockDefaultProps = { | ||
| isSectionDisabled: false, | ||
| setAPL: vi.fn(), | ||
| setHighAvailability: vi.fn(), | ||
| }; | ||
|
|
||
| describe('ApplicationPlatform', () => { | ||
| it('renders enabled but unchecked radio buttons with the section enabled', () => { | ||
| const { getByRole } = renderWithTheme( | ||
| <ApplicationPlatform {...MockDefaultProps} /> | ||
| ); | ||
| const yesRadio = getByRole('radio', { name: /yes/i }); | ||
| const noRadio = getByRole('radio', { name: /no/i }); | ||
|
|
||
| expect(yesRadio).toBeEnabled(); | ||
| expect(yesRadio).not.toBeChecked(); | ||
| expect(noRadio).toBeEnabled(); | ||
| expect(noRadio).not.toBeChecked(); | ||
| }); | ||
|
|
||
| it('toggles checked state correctly with the section enabled', async () => { | ||
| const { getByRole } = renderWithTheme( | ||
| <ApplicationPlatform {...MockDefaultProps} /> | ||
| ); | ||
| const yesRadio = getByRole('radio', { name: /yes/i }); | ||
| const noRadio = getByRole('radio', { name: /no/i }); | ||
|
|
||
| // Confirm both buttons can be clicked. | ||
| await userEvent.click(yesRadio); | ||
| expect(yesRadio).toBeChecked(); | ||
| expect(noRadio).not.toBeChecked(); | ||
|
|
||
| await userEvent.click(noRadio); | ||
| expect(noRadio).toBeChecked(); | ||
| expect(yesRadio).not.toBeChecked(); | ||
| }); | ||
|
|
||
| it('renders disabled radio buttons and the "no" option checked with the section disabled', () => { | ||
| const { getByRole } = renderWithTheme( | ||
| <ApplicationPlatform {...MockDefaultProps} isSectionDisabled /> | ||
| ); | ||
| const yesRadio = getByRole('radio', { name: /yes/i }); | ||
| const noRadio = getByRole('radio', { name: /no/i }); | ||
|
|
||
| expect(yesRadio).toBeDisabled(); | ||
| expect(yesRadio).not.toBeChecked(); | ||
| expect(noRadio).toBeDisabled(); | ||
| expect(noRadio).toBeChecked(); | ||
| }); | ||
| }); |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.