change: [M3-9601] - Replace Label with Bucket Name#11877
Merged
jaalah-akamai merged 7 commits intolinode:developfrom Mar 19, 2025
Merged
change: [M3-9601] - Replace Label with Bucket Name#11877jaalah-akamai merged 7 commits intolinode:developfrom
jaalah-akamai merged 7 commits intolinode:developfrom
Conversation
coliu-akamai
approved these changes
Mar 18, 2025
Contributor
There was a problem hiding this comment.
✅ can still create buckets
✅ validation looks good (should Name in Bucket Name be capitalized for the validation message?)
❓ I'm seeing some test failures - approving pending their resolution:
- unit test failure in
OMC_CreateBucketDrawer.test.tsxlooks relevant - There are some additional cypress tests that still use label inside the objectStoragegen2/objectStorageMulticluster packages
- bucket-create-gen2.spec.ts
- bucket-create-multicluster.spec.ts
thanks Jaalah!
Contributor
Author
|
Thanks @coliu-akamai that should do it, but I'll check the e2e pipeline for anything else 👍 |
bnussman-akamai
approved these changes
Mar 19, 2025
Collaborator
Cloud Manager UI test results🔺 1 failing test on test run #4 ↗︎
Details
TroubleshootingUse this command to re-run the failing tests: pnpm cy:run -s "cypress/e2e/core/firewalls/update-firewall.spec.ts" |
|||||||||||||||||
This was referenced Mar 20, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

Description 📝
Update the input field title in the bucket creation form from "Label" to "Bucket Name" to improve clarity. While the API refers to this field as
label, using "Bucket Name" in the UI will prevent future confusion when bucket tagging is implemented.Note
Technical Details: No changes to API contract required. UI change only, backend will continue to use
labelfield nameChanges 🔄
LabeltoBucket NameTarget release date 🗓️
3/25
Preview 📷
How to test 🧪
Prerequisites
Verification steps
Author Checklists
As an Author, to speed up the review process, I considered 🤔
👀 Doing a self review
❔ Our contribution guidelines
🤏 Splitting feature into small PRs
➕ Adding a changeset
🧪 Providing/improving test coverage
🔐 Removing all sensitive information from the code and PR description
🚩 Using a feature flag to protect the release
👣 Providing comprehensive reproduction steps
📑 Providing or updating our documentation
🕛 Scheduling a pair reviewing session
📱 Providing mobile support
♿ Providing accessibility support
As an Author, before moving this PR from Draft to Open, I confirmed ✅