upcoming: [M3-9517] - Update LKE-E flows to account for LDE being disabled at LA launch#11880
Merged
mjac0bs merged 3 commits intolinode:developfrom Mar 19, 2025
Merged
Conversation
mjac0bs
commented
Mar 18, 2025
Contributor
Author
There was a problem hiding this comment.
This was an unrelated change, but something I caught from the mocks. Enterprise clusters don't have the 250 maximum.
mjac0bs
commented
Mar 18, 2025
Contributor
Author
There was a problem hiding this comment.
@dwiley-akamai Hopefully this explains the situation well enough here and in the below file. 😅
ba4a82e to
23d7961
Compare
bnussman-akamai
approved these changes
Mar 19, 2025
Collaborator
Cloud Manager UI test results🎉 539 passing tests on test run #3 ↗︎
|
dwiley-akamai
approved these changes
Mar 19, 2025
Contributor
dwiley-akamai
left a comment
There was a problem hiding this comment.
-
LKE Create page copy, incl. for LKE-E ✅
-
No tooltip for LKE-E Node Pool encryption statuses ✅
-
Linode Details page of an LKE Linode --> no encryption status tooltip re: enabling LDE ✅
- however, if the node pool has a "Not Encrypted" status and I go to the Linode Details page of any of the pool's linodes, the linode has an "Encrypted" status -- but this is an API/back-end bug that has been ticketed, right?
Contributor
Author
Yes. I confirmed with Medhat that the expected behavior is that that will also be |
This was referenced Mar 20, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description 📝
This is a late add that came out of reviews ahead of LKE-E's LA release.
The ask is to expose the fact that LDE is not enabled for the cluster during the cluster creation time. It is not sufficient to show it in the UI after the cluster is created or to just have it in tech docs.
Reasons LDE may not be enabled:
This changes will be reversed in coming weeks when LDE becomes available for LKE-E. Given potential merge conflicts with the last LDE changes in staging and the fact that this is not long-lasting, I did not go through the hassle of adding test coverage.
Changes 🔄
Target release date 🗓️
3/25
Preview 📷
How to test 🧪
Prerequisites
(How to setup test environment)
Reproduction steps
(How to reproduce the issue, if applicable)
Verification steps
(How to verify changes)
Author Checklists
As an Author, to speed up the review process, I considered 🤔
👀 Doing a self review
❔ Our contribution guidelines
🤏 Splitting feature into small PRs
➕ Adding a changeset
🧪 Providing/improving test coverage
🔐 Removing all sensitive information from the code and PR description
🚩 Using a feature flag to protect the release
👣 Providing comprehensive reproduction steps
📑 Providing or updating our documentation
🕛 Scheduling a pair reviewing session
📱 Providing mobile support
♿ Providing accessibility support
As an Author, before moving this PR from Draft to Open, I confirmed ✅