Skip to content

Comments

upcoming: [UIE-8516] - DBaaS: Advanced Configuration (Part 2) - add/remove configs#11885

Merged
cpathipa merged 14 commits intolinode:developfrom
mpolotsk-akamai:UIE-8515-drawer-add-configs
Apr 1, 2025
Merged

upcoming: [UIE-8516] - DBaaS: Advanced Configuration (Part 2) - add/remove configs#11885
cpathipa merged 14 commits intolinode:developfrom
mpolotsk-akamai:UIE-8515-drawer-add-configs

Conversation

@mpolotsk-akamai
Copy link
Contributor

@mpolotsk-akamai mpolotsk-akamai commented Mar 19, 2025

Description 📝

DBaaS: Advanced Configuration (Part 2) – Add and Remove Configurations.

This PR continues the implementation of the Drawer functionality, building on the first part.
The first part can be found in PR #11812.

Changes 🔄

List any change(s) relevant to the reviewer.

  • Setup Autocomplete to show options with categories
  • Functionality for adding/removing configs
  • PUT call with formatted payload to update database instance with the new config options
  • Dynamic Validation Schema for all types of fields

Target release date 🗓️

04/08/25

Preview 📷

Include a screenshot or screen recording of the change.

Before After
Screenshot 2025-03-19 at 4 06 50 PM Screenshot 2025-03-19 at 3 56 25 PM
Screenshot 2025-03-19 at 4 07 03 PM Screenshot 2025-03-19 at 3 56 52 PM

How to test 🧪

Prerequisites

(How to setup test environment)

  • Database Advanced Config feature flag should be enabled
  • mock data should be enabled

Verification steps

(How to verify changes)

  • select a database cluster
  • navigate to the Advanced Configuration Tab
  • use mock data to see table with existing configurations
  • click 'Configure' button
  • drawer with all existing configurations is shown, the "Save" button is disabled
  • select a new configuration from the Autocomplete and click 'Add' button
  • new configuration is added to the list
  • change the value or click the remove icon to remove this configuration
  • if the configuration has 'restart service' label, the button text changes from 'Save' to 'Save and Restart service'
Author Checklists

As an Author, to speed up the review process, I considered 🤔

👀 Doing a self review
❔ Our contribution guidelines
🤏 Splitting feature into small PRs
➕ Adding a changeset
🧪 Providing/improving test coverage
🔐 Removing all sensitive information from the code and PR description
🚩 Using a feature flag to protect the release
👣 Providing comprehensive reproduction steps
📑 Providing or updating our documentation
🕛 Scheduling a pair reviewing session
📱 Providing mobile support
♿ Providing accessibility support


  • I have read and considered all applicable items listed above.

As an Author, before moving this PR from Draft to Open, I confirmed ✅

  • All unit tests are passing
  • TypeScript compilation succeeded without errors
  • Code passes all linting rules

@mpolotsk-akamai mpolotsk-akamai requested a review from a team as a code owner March 19, 2025 15:23
@mpolotsk-akamai mpolotsk-akamai requested review from bill-akamai and dwiley-akamai and removed request for a team March 19, 2025 15:23
@mpolotsk-akamai mpolotsk-akamai self-assigned this Mar 19, 2025
@mjac0bs mjac0bs added the DBaaS Relates to Database as a Service label Mar 19, 2025
@cpathipa cpathipa requested review from cpathipa and removed request for dwiley-akamai March 19, 2025 18:58
Copy link
Contributor

@bill-akamai bill-akamai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @mpolotsk-akamai, confirmed all verification steps

@mpolotsk-akamai mpolotsk-akamai force-pushed the UIE-8515-drawer-add-configs branch from aec0007 to 7d0cf78 Compare March 26, 2025 14:53
Copy link
Contributor

@cpathipa cpathipa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @mpolotsk-akamai LGTM! Confirming on the verification steps.

@github-project-automation github-project-automation bot moved this from Review to Approved in Cloud Manager Mar 31, 2025
@cpathipa cpathipa added the Approved Multiple approvals and ready to merge! label Mar 31, 2025
@linode-gh-bot
Copy link
Collaborator

Cloud Manager UI test results

🎉 536 passing tests on test run #9 ↗︎

❌ Failing✅ Passing↪️ Skipped🕐 Duration
0 Failing536 Passing4 Skipped109m 14s

@cpathipa cpathipa merged commit 206a977 into linode:develop Apr 1, 2025
27 of 28 checks passed
@github-project-automation github-project-automation bot moved this from Approved to Merged in Cloud Manager Apr 1, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Approved Multiple approvals and ready to merge! DBaaS Relates to Database as a Service

Projects

Archived in project

Development

Successfully merging this pull request may close these issues.

5 participants