fix: [UIE-10203], [UIE-10223], [UIE-10237] - IAM Delegate Users bug fix#13399
fix: [UIE-10203], [UIE-10223], [UIE-10237] - IAM Delegate Users bug fix#13399mpolotsk-akamai wants to merge 2 commits intolinode:developfrom
Conversation
3f983a1 to
db3b36b
Compare
a5676ee to
aa25a0f
Compare
| }); | ||
| onClose(event); | ||
| location.reload(); | ||
| location.replace('/linodes'); |
There was a problem hiding this comment.
How was the decision made to redirect to /linodes ?
There was a problem hiding this comment.
This was agreed upon in the Figma discussion (UIE-10203), where /linodes was chosen as the default landing page.
There was a problem hiding this comment.
Just heads up that the default page for managed users isn't /linodes tho i am not sure it is super important
| </TableRow> | ||
| ))} | ||
| {(childAccounts?.results ?? 0) > pagination.pageSize && ( | ||
| {(childAccounts?.results ?? 0) > MIN_PAGE_SIZE && ( |
There was a problem hiding this comment.
just curious why it's not a table + footer ( like in AccountDelegations or Users)
There was a problem hiding this comment.
This wasn’t part of the changes in this PR, so I don’t have context on the original decision. We can handle the refactoring in a separate ticket if needed.
… switch, wrong top menu username, pagination disappears in the User Delegations table
888d660 to
37fb641
Compare
Cloud Manager UI test results🔺 1 failing test on test run #7 ↗︎
Details
TroubleshootingUse this command to re-run the failing tests: pnpm cy:run -s "cypress/e2e/core/parentChild/account-switching.spec.ts" |
|||||||||||||||||
Description 📝
This PR fixes issues related to account switching and delegations: it ensures the default landing page is the Linodes page, correctly displays the delegate username in the top menu, fixes pagination bug in the User Delegations table.
Changes 🔄
List any change(s) relevant to the reviewer.
Scope 🚢
Upon production release, changes in this PR will be visible to:
How to test 🧪
Prerequisites
(How to setup test environment)
Verification steps
(How to reproduce the issue, if applicable)
Pagination:
Author Checklists
As an Author, to speed up the review process, I considered 🤔
👀 Doing a self review
❔ Our contribution guidelines
🤏 Splitting feature into small PRs
➕ Adding a changeset
🧪 Providing/improving test coverage
🔐 Removing all sensitive information from the code and PR description
🚩 Using a feature flag to protect the release
👣 Providing comprehensive reproduction steps
📑 Providing or updating our documentation
🕛 Scheduling a pair reviewing session
📱 Providing mobile support
♿ Providing accessibility support
As an Author, before moving this PR from Draft to Open, I confirmed ✅