Skip to content

Comments

change: [UIE-9888] - Make firewall selection mandatory while creating linode and its interfaces#13410

Draft
grevanak-akamai wants to merge 2 commits intolinode:developfrom
grevanak-akamai:feature/UIE-10132-block-interface-creation-without-firewall
Draft

change: [UIE-9888] - Make firewall selection mandatory while creating linode and its interfaces#13410
grevanak-akamai wants to merge 2 commits intolinode:developfrom
grevanak-akamai:feature/UIE-10132-block-interface-creation-without-firewall

Conversation

@grevanak-akamai
Copy link
Contributor

Description 📝

Make firewall selection mandatory while creating linode and its interfaces. If there are no firewalls or user doesn't wants to assign a firewall to a linode, No firewall option can be selected but the firewall field cannot be left blank.

Changes 🔄

List any change(s) relevant to the reviewer.

  • ...
  • ...

Scope 🚢

Upon production release, changes in this PR will be visible to:

  • All customers
  • Some customers (e.g. in Beta or Limited Availability)
  • No customers / Not applicable

Target release date 🗓️

Please specify a release date (and environment, if applicable) to guarantee timely review of this PR. If exact date is not known, please approximate and update it as needed.

Preview 📷

Include a screenshot <img src="" /> or video <video src="" /> of the change.

🔒 Use the Mask Sensitive Data setting for security.

💡 For changes requiring multiple steps to validate, prefer a video for clarity.

Before After
📷 📷

How to test 🧪

Prerequisites

(How to setup test environment)

  • ...
  • ...

Reproduction steps

(How to reproduce the issue, if applicable)

  • ...
  • ...

Verification steps

(How to verify changes)

  • ...
  • ...
Author Checklists

As an Author, to speed up the review process, I considered 🤔

👀 Doing a self review
❔ Our contribution guidelines
🤏 Splitting feature into small PRs
➕ Adding a changeset
🧪 Providing/improving test coverage
🔐 Removing all sensitive information from the code and PR description
🚩 Using a feature flag to protect the release
👣 Providing comprehensive reproduction steps
📑 Providing or updating our documentation
🕛 Scheduling a pair reviewing session
📱 Providing mobile support
♿ Providing accessibility support


  • I have read and considered all applicable items listed above.

As an Author, before moving this PR from Draft to Open, I confirmed ✅

  • All tests and CI checks are passing
  • TypeScript compilation succeeded without errors
  • Code passes all linting rules

@grevanak-akamai grevanak-akamai force-pushed the feature/UIE-10132-block-interface-creation-without-firewall branch from c096c03 to 4844424 Compare February 18, 2026 11:07

export const CreateLinodeInterfaceSchema = object({
firewall_id: number().nullable(),
firewall_id: number()
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

API accepts both -1 and null to not to assign a firewall to a linode and hence firewall field has been made mandatory in UI.

@linode-gh-bot
Copy link
Collaborator

Cloud Manager UI test results

🔺 8 failing tests on test run #3 ↗︎

❌ Failing✅ Passing↪️ Skipped🕐 Duration
8 Failing856 Passing11 Skipped69m 35s

Details

Failing Tests
SpecTest
backup-linode.spec.tsCloud Manager Cypress Tests→linode backups » can capture a manual snapshot
create-linode-with-firewall.spec.tsCloud Manager Cypress Tests→Create Linode with Firewall (Linode Interfaces) » can generate and assign a compliant Firewall during Linode Create flow (legacy)
create-stackscripts.spec.tsCloud Manager Cypress Tests→Create stackscripts » creates a StackScript and deploys a Linode with it
create-stackscripts.spec.tsCloud Manager Cypress Tests→Create stackscripts » creates a StackScript with Any/All target image
smoke-community-stackscripts.spec.tsCloud Manager Cypress Tests→Community Stackscripts integration tests » deploys a new linode as expected
clone-linode.spec.tsCloud Manager Cypress Tests→clone linode » can clone a Linode from Linode details page
clone-linode.spec.tsCloud Manager Cypress Tests→clone linode » can clone a Linode with null type
create-linode.spec.tsCloud Manager Cypress Tests→Create Linode→End-to-end→By plan type » creates a Shared CPU Linode

Troubleshooting

Use this command to re-run the failing tests:

pnpm cy:run -s "cypress/e2e/core/linodes/backup-linode.spec.ts,cypress/e2e/core/linodes/create-linode-with-firewall.spec.ts,cypress/e2e/core/stackscripts/create-stackscripts.spec.ts,cypress/e2e/core/stackscripts/smoke-community-stackscripts.spec.ts,cypress/e2e/core/linodes/clone-linode.spec.ts,cypress/e2e/core/linodes/create-linode.spec.ts"

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Status: Review

Development

Successfully merging this pull request may close these issues.

2 participants