TPT-4431: Added support for SLADE and CLEO features#431
Open
ezilber-akamai wants to merge 5 commits intolinode:devfrom
Open
TPT-4431: Added support for SLADE and CLEO features#431ezilber-akamai wants to merge 5 commits intolinode:devfrom
ezilber-akamai wants to merge 5 commits intolinode:devfrom
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR updates the Linode Packer builder to support new instance/disk creation capabilities (notably optional root_pass when alternative auth is provided, plus new instance boot_size and kernel options), and temporarily points the plugin at a linodego fork that contains the required API surface.
Changes:
- Make
root_passoptional for instance creation (and disk creation) whenauthorized_keysorauthorized_usersare provided. - Add
boot_sizeandkernelfields to instance creation and configuration decoding/docs. - Update network interface flattening/tests to match updated linodego types (e.g.,
firewall_idpointer semantics).
Reviewed changes
Copilot reviewed 9 out of 10 changed files in this pull request and generated 4 comments.
Show a summary per file
| File | Description |
|---|---|
| go.mod | Adds a replace to a linodego fork to access new API fields/types. |
| go.sum | Updates module sums to reflect the linodego fork replacement. |
| builder/linode/config.go | Makes root_pass optional, adds validation rules, and introduces boot_size/kernel config fields. |
| builder/linode/config.hcl2spec.go | Adds HCL decoding support for boot_size, kernel, and disk-level root_pass. |
| builder/linode/step_create_linode.go | Sends root_pass as-is and adds boot_size/kernel to instance create options. |
| builder/linode/step_create_disk_config.go | Adds disk-level root_pass propagation and removes implicit password fallback behavior. |
| builder/linode/step_create_linode_test.go | Adjusts tests for updated firewall_id pointer shape. |
| builder/linode/config_test.go | Updates config prepare test inputs to satisfy new auth validation. |
| builder/linode/builder_test.go | Adds/updates tests covering root_pass optionality and boot_size/kernel behavior. |
| .web-docs/components/builder/linode/README.md | Documents boot_size/kernel and the updated auth requirements. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
mgwoj
approved these changes
May 4, 2026
8b65066 to
de15ff5
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
📝 Description
Made
root_passoptional for instance and instance disk creation (so long as at least one of authorized_users or authorized_keys is provided). Also added newboot_sizeandkernelfields to instance creation.Also removed automatic root password generation to align with the fact that the field is now optional.
✔️ How to Test
make unit-testmake int-test