Skip to content

TPT-4431: Added support for SLADE and CLEO features#431

Open
ezilber-akamai wants to merge 5 commits intolinode:devfrom
ezilber-akamai:TPT-4431-slade-cleo
Open

TPT-4431: Added support for SLADE and CLEO features#431
ezilber-akamai wants to merge 5 commits intolinode:devfrom
ezilber-akamai:TPT-4431-slade-cleo

Conversation

@ezilber-akamai
Copy link
Copy Markdown
Contributor

@ezilber-akamai ezilber-akamai commented May 1, 2026

📝 Description

Made root_pass optional for instance and instance disk creation (so long as at least one of authorized_users or authorized_keys is provided). Also added new boot_size and kernel fields to instance creation.

Also removed automatic root password generation to align with the fact that the field is now optional.

✔️ How to Test

make unit-test
make int-test

@ezilber-akamai ezilber-akamai added breaking-change for breaking changes in the changelog. project for new projects in the changelog. do-not-merge PRs that should not be merged until the commented issue is resolved labels May 1, 2026
@ezilber-akamai ezilber-akamai marked this pull request as ready for review May 1, 2026 14:25
@ezilber-akamai ezilber-akamai requested review from a team as code owners May 1, 2026 14:25
@ezilber-akamai ezilber-akamai requested review from mgwoj and psnoch-akamai and removed request for a team May 1, 2026 14:25
@ezilber-akamai ezilber-akamai changed the title Added support for SLADE and CLEO features TPT-4431: Added support for SLADE and CLEO features May 1, 2026
@ezilber-akamai ezilber-akamai requested a review from Copilot May 1, 2026 15:50
Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR updates the Linode Packer builder to support new instance/disk creation capabilities (notably optional root_pass when alternative auth is provided, plus new instance boot_size and kernel options), and temporarily points the plugin at a linodego fork that contains the required API surface.

Changes:

  • Make root_pass optional for instance creation (and disk creation) when authorized_keys or authorized_users are provided.
  • Add boot_size and kernel fields to instance creation and configuration decoding/docs.
  • Update network interface flattening/tests to match updated linodego types (e.g., firewall_id pointer semantics).

Reviewed changes

Copilot reviewed 9 out of 10 changed files in this pull request and generated 4 comments.

Show a summary per file
File Description
go.mod Adds a replace to a linodego fork to access new API fields/types.
go.sum Updates module sums to reflect the linodego fork replacement.
builder/linode/config.go Makes root_pass optional, adds validation rules, and introduces boot_size/kernel config fields.
builder/linode/config.hcl2spec.go Adds HCL decoding support for boot_size, kernel, and disk-level root_pass.
builder/linode/step_create_linode.go Sends root_pass as-is and adds boot_size/kernel to instance create options.
builder/linode/step_create_disk_config.go Adds disk-level root_pass propagation and removes implicit password fallback behavior.
builder/linode/step_create_linode_test.go Adjusts tests for updated firewall_id pointer shape.
builder/linode/config_test.go Updates config prepare test inputs to satisfy new auth validation.
builder/linode/builder_test.go Adds/updates tests covering root_pass optionality and boot_size/kernel behavior.
.web-docs/components/builder/linode/README.md Documents boot_size/kernel and the updated auth requirements.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Comment thread builder/linode/config.go
Comment thread builder/linode/config.go
Comment thread builder/linode/config.go Outdated
Comment thread go.mod
@ezilber-akamai ezilber-akamai removed the do-not-merge PRs that should not be merged until the commented issue is resolved label May 7, 2026
@ezilber-akamai ezilber-akamai force-pushed the TPT-4431-slade-cleo branch from 8b65066 to de15ff5 Compare May 7, 2026 19:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

breaking-change for breaking changes in the changelog. project for new projects in the changelog.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants