null_blk: Align struct nullb_device field types with module parameters #404
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Author
|
Upstream branch: fd95357 |
blktests-ci
bot
force-pushed
the
linus-master_base
branch
from
6f43942 to
ec9caac
Compare
The struct nullb_device previously used generic int types for several fields that represent boolean flags, unsigned counters, or large size values. This patch updates the field types to improve type safety and match the corresponding module parameters: - Change boolean fields to bool (e.g., no_sched, virt_boundary) - Change counters and queue-related fields to unsigned int - Change size-related fields (size, cache_size, zone_size, zone_capacity) to unsigned long This ensures consistency between module_param declarations and internal data structures, prevents negative values for unsigned parameters. The output of modinfo before and after applying this patch is as follows: Before: [...] parm: no_sched:No io scheduler (int) parm: submit_queues:Number of submission queues (int) parm: poll_queues:Number of IOPOLL submission queues (int) parm: home_node:Home node for the device (int) [...] parm: gb:Size in GB (int) parm: bs:Block size (in bytes) (int) parm: max_sectors:Maximum size of a command (in 512B sectors) (int) [...] parm: hw_queue_depth:Queue depth for each hardware queue. Default: 64 (int) [...] parm: zone_append_max_sectors:Maximum size of a zone append command (in 512B sectors). Specify 0 for zone append emulation (int) After: [...] parm: no_sched:No io scheduler (bool) parm: submit_queues:Number of submission queues (uint) parm: poll_queues:Number of IOPOLL submission queues (uint) parm: home_node:Home node for the device (uint) [...] parm: gb:Size in GB (ulong) parm: bs:Block size (in bytes) (uint) parm: max_sectors:Maximum size of a command (in 512B sectors) (uint) [...] parm: hw_queue_depth:Queue depth for each hardware queue. Default: 64 (uint) [...] parm: zone_append_max_sectors:Maximum size of a zone append command (in 512B sectors). Specify 0 for zone append emulation (uint) Signed-off-by: shechenglong <shechenglong@xfusion.com>
Author
|
Upstream branch: c2f2b01 |
blktests-ci
bot
force-pushed
the
series/1026312=>linus-master
branch
from
ed9d72a to
9c65273
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull request for series with
subject: null_blk: Align struct nullb_device field types with module parameters
version: 1
url: https://patchwork.kernel.org/project/linux-block/list/?series=1026312