Skip to content

nvmet-tcp: Ensure old keys are freed before replacing new ones #744

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
blktests-ci wants to merge 1 commit into
base: linus-master_base
Choose a base branch
from
+7 −0
Open

nvmet-tcp: Ensure old keys are freed before replacing new ones #744

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 7 additions & 0 deletions drivers/nvme/target/fabrics-cmd-auth.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -411,6 +411,13 @@ static int nvmet_auth_challenge(struct nvmet_req *req, void *d, int al)
int hash_len = nvme_auth_hmac_hash_len(ctrl->shash_id);
int data_size = sizeof(*d) + hash_len;

/*
* If replacing the keys then we have previous successful keys
* that might be leaked, so we need to free them here.
*/
if (req->sq->dhchap_c1)
nvmet_auth_sq_free(req->sq);

if (ctrl->dh_tfm)
data_size += ctrl->dh_keysize;
if (al < data_size) {
Expand Down