floppy: select FDC before arming timeout work#794
Open
blktests-ci[bot] wants to merge 1 commit intolinus-master_basefrom
Open
floppy: select FDC before arming timeout work#794blktests-ci[bot] wants to merge 1 commit intolinus-master_basefrom
blktests-ci[bot] wants to merge 1 commit intolinus-master_basefrom
Conversation
Author
|
Upstream branch: 66edb90 |
blktests-ci
Bot
force-pushed
the
linus-master_base
branch
from
25a041f to
6f75bd1
Compare
Author
|
Upstream branch: 6d35786 |
blktests-ci
Bot
force-pushed
the
series/1089071=>linus-master
branch
from
a9fdbdb to
42fb4e8
Compare
blktests-ci
Bot
force-pushed
the
linus-master_base
branch
from
6f75bd1 to
1f0d33a
Compare
floppy_shutdown() uses current_fdc to choose which controller state to mark for reset when fd_timeout expires. lock_fdc() currently arms that timeout before set_fdc() has selected the drive/FDC and updated current_drive/current_fdc. drive_params[drive].timeout is user configurable, so the timeout can be immediate. Even with a non-zero timeout, a delayed caller can leave the timeout work running while set_fdc() is still testing fdc_state[fdc].rawcmd and updating the adjacent reset bitfield. The timeout can then use stale selected-controller state or race the reset bitfield update. Move the timeout arm after set_fdc() in lock_fdc(), and keep the same ordering for the direct floppy_queue_rq() path. This ensures fd_timeout cannot run until the selected-controller state describes the operation being timed. Fixes: 1da177e ("Linux-2.6.12-rc2") Signed-off-by: Cen Zhang <zzzccc427@gmail.com> Reviewed-by: Denis Efremov (Oracle) <efremov@linux.com>
Author
|
Upstream branch: 6d35786 |
blktests-ci
Bot
force-pushed
the
series/1089071=>linus-master
branch
from
42fb4e8 to
4e2d5c3
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pull request for series with
subject: floppy: select FDC before arming timeout work
version: 1
url: https://patchwork.kernel.org/project/linux-block/list/?series=1089071