Skip to content

libibverbs: Skip zero-length memcpy in fill_attr_in() #1669

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
zengyijing wants to merge 1 commit into
base: master
Choose a base branch
from
Open

libibverbs: Skip zero-length memcpy in fill_attr_in() #1669

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 5 additions & 3 deletions libibverbs/cmd_ioctl.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -280,10 +280,12 @@ fill_attr_in(struct ibv_command_buffer *cmd, uint16_t attr_id, const void *data,
cmd->buffer_error = 1;

attr->len = len;
if (len <= sizeof(uint64_t))
memcpy(&attr->data, data, len);
else
if (len <= sizeof(uint64_t)) {
if (len > 0)
memcpy(&attr->data, data, len);
} else {
attr->data = ioctl_ptr_to_u64(data);
}

return attr;
}
Expand Down