Skip to content

refactor(builder): eliminate code smells in builder module#14

Merged
flexiondotorg merged 1 commit intomainfrom
clean-up
Mar 12, 2026
Merged

refactor(builder): eliminate code smells in builder module#14
flexiondotorg merged 1 commit intomainfrom
clean-up

Conversation

@flexiondotorg
Copy link
Contributor

  • Remove dead Enabled() helper function from pointer.go
  • Fix resource leak: move ticker.Stop() outside retry loop in download.go
  • Flatten single-element slice loop in state.go
  • Replace magic string sentinels with pointer identity checks in libraries.go
  • Extract duplicated SDK path extraction logic into extractSDKPath() helper

Checklist

  • I have performed a self-review of my code
  • I have tested my changes and confirmed there are no regressions

- Remove dead Enabled() helper function from pointer.go
- Fix resource leak: move ticker.Stop() outside retry loop in
  download.go
- Flatten single-element slice loop in state.go
- Replace magic string sentinels with pointer identity checks in
  libraries.go
- Extract duplicated SDK path extraction logic into extractSDKPath()
  helper

Signed-off-by: Martin Wimpress <code@wimpress.io>
Copy link

@cubic-dev-ai cubic-dev-ai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No issues found across 6 files

Confidence score: 5/5

  • Automated review surfaced no issues in the provided summaries.
  • No files require special attention.

Requires human review: Refactor touches core logic across multiple files, including resource management in download.go and library ordering in libraries.go, which require human verification.

@flexiondotorg flexiondotorg merged commit 5f355e3 into main Mar 12, 2026
7 checks passed
@flexiondotorg flexiondotorg deleted the clean-up branch March 12, 2026 23:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant