ci(workflow): adopt unified tailor sentinel gate pattern and consolidate release mechanism#62
Merged
flexiondotorg merged 2 commits intomainfrom Mar 16, 2026
Merged
ci(workflow): adopt unified tailor sentinel gate pattern and consolidate release mechanism#62flexiondotorg merged 2 commits intomainfrom
flexiondotorg merged 2 commits intomainfrom
Conversation
…ate release mechanism - Replace separate build.yml and release.yml with unified builder.yml workflow - Implement sentinel gate pattern: lint-code, lint-actions, coverage, test matrix, security - Preserve native four-runner build matrix with CGO and ffmpeg-statigo - Retain existing softprops/action-gh-release mechanism - Add actionlint-matcher.json for improved error reporting Signed-off-by: Martin Wimpress <code@wimpress.io>
Contributor
There was a problem hiding this comment.
3 issues found across 4 files
Confidence score: 2/5
- High-confidence CI regression in
.github/workflows/builder.yml: theffmpeg-statigosubmodule is not initialized before Go linters, sogo vetcan fail on the./third_party/ffmpeg-statigoreplace target and block the sentinel gate. - Given the severity (8/10) and strong confidence (9/10), this is a likely merge blocker rather than a cosmetic issue, which drives the lower score.
- There are also smaller workflow-quality issues:
.github/actionlint-matcher.jsonmay miss ANSI diagnostics with semicolon-delimited SGR codes, and.github/workflows/builder.ymlrelease notes currently claim SHA256 assets that are not produced. - Pay close attention to
.github/workflows/builder.yml,.github/actionlint-matcher.json- fix submodule setup first to restore CI reliability, then align matcher/release-note behavior.
Prompt for AI agents (unresolved issues)
Check if these issues are valid — if so, understand the root cause of each and fix them. If appropriate, use sub-agents to investigate and fix each issue separately.
<file name=".github/actionlint-matcher.json">
<violation number="1" location=".github/actionlint-matcher.json:7">
P2: Broaden the ANSI matcher to handle semicolon-delimited SGR codes, otherwise colored diagnostics with combined attributes can stop matching.</violation>
</file>
<file name=".github/workflows/builder.yml">
<violation number="1" location=".github/workflows/builder.yml:30">
P1: Initialize the ffmpeg-statigo submodule before running Go linters. This checkout omits the local module that `go.mod` replaces into `./third_party/ffmpeg-statigo`, so `go vet` fails in CI and blocks the sentinel gate.</violation>
<violation number="2" location=".github/workflows/builder.yml:253">
P3: Either generate checksum assets or remove this sentence. As written, every release note claims SHA256 checksums are included even though the workflow never creates them.</violation>
</file>
Reply with feedback, questions, or to request a fix. Tag @cubic-dev-ai to re-run a review.
- Add `submodules: recursive` to lint-code checkout step to load go.mod replace directive targeting third_party/ffmpeg-statigo - Add `submodules: recursive` to security checkout step and set `repo-checkout: false` on govulncheck-action to prevent duplicate checkout without submodule initialisation Fixes go vet and govulncheck job failures caused by missing submodule dependencies. Signed-off-by: Martin Wimpress <code@wimpress.io>
|
You are seeing this message because GitHub Code Scanning has recently been set up for this repository, or this pull request contains the workflow file for the Code Scanning tool. What Enabling Code Scanning Means:
For more information about GitHub Code Scanning, check out the documentation. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Checklist