Revert 23aba56e6d (ignore XkbNewKeyboardNotify) - filter by req_minor code. #782
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mtwebster
force-pushed
the
restore-XkbNewKeyboardNotify
branch
from
d444cd8 to
3baf77c
Compare
req_minor code. Originally removed because keymap_changed() was being called in ordinary use - with multiple devices involved (a volume knob on a keyboard is considered a separate device), a freeze could occur when switching between them. Unfortunately, the updating of xkb options also triggers this event, and ignoring it was causing Muffin keybinding handling of iso-next- group (grp) xkb option changes to be ignored, including at the beginning of a session when the xkb options are first applied. Re-add this event case, but check the event's req_minor value to determine whether or not to call keymap_changed() - hotplug and set_keymap() events have the same code, and should be handled. ref: https://gitlab.gnome.org/GNOME/mutter/-/issues/398 linuxmint/cinnamon#13361
mtwebster
force-pushed
the
restore-XkbNewKeyboardNotify
branch
from
3f71ef2 to
2f7dd1d
Compare
Member
Author
|
/generate-test-packages 7 |
|
Test packages generated successfully! Download from the workflow run (available for 7 days). |
mtwebster
force-pushed
the
restore-XkbNewKeyboardNotify
branch
from
e1fba84 to
2f7dd1d
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Originally removed because keymap_changed() was being called in ordinary use - with multiple devices involved (a volume knob on a keyboard is considered a separate device), a freeze could occur when switching between them.
Unfortunately, the updating of xkb options also triggers this event, and ignoring it was causing Muffin keybinding handling of iso-next- group (grp) xkb option changes to be ignored, including at the beginning of a session when the xkb options are first applied.
Re-add this event case, but check the event's req_minor value to determine whether or not to call keymap_changed() - hotplug and set_keymap() events have the same code, and should be handled.
ref:
https://gitlab.gnome.org/GNOME/mutter/-/issues/398 linuxmint/cinnamon#13361
linuxmint/cinnamon#13361