implement version-based hashing (SHA1/SHA3-256)#40
Open
alexsyvolap wants to merge 4 commits intoliqpay:masterfrom
Open
implement version-based hashing (SHA1/SHA3-256)#40alexsyvolap wants to merge 4 commits intoliqpay:masterfrom
alexsyvolap wants to merge 4 commits intoliqpay:masterfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Currently, the SDK uses SHA-1 for all signature generations. According to the latest LiqPay API requirements, newer integration versions (specifically version: 7 and above) require the SHA3-256 hashing algorithm.
The current implementation does not support SHA3-256, which prevents using the SDK with the latest API features.
Proposed Solution
Update the signature generation logic to automatically select the hashing algorithm based on the version parameter provided in the request:
Key Changes
Backward Compatibility
This change is fully backward compatible. Existing integrations using API v3 (or any version below 7) will continue to use SHA-1 by default