Toolset.create#1584
Open
toubatbrian wants to merge 9 commits into
Open
Conversation
Brings the public tool surface in line with `livekit-agents` Python:
- Tool gains an `id: string` field on the base interface. `FunctionTool.id`
mirrors `name`; for `ProviderTool` it's the provider tool id. `ToolContext`
keys and equality use `tool.id` consistently
(matches Python's `_fnc_tools_map[tool.info.name]`).
- `ProviderDefinedTool` → `ProviderTool`, converted from an interface to
an `abstract class`. Plugins now subclass it
(`class WebSearch extends ProviderTool { ... }`) to attach
provider-specific fields and serializers, mirroring Python's
`OpenAITool(ProviderTool, ABC)` / `WebSearch(OpenAITool)` chain.
The unused `config: Record<string, unknown>` field is dropped, and the
`tool({ id })` factory overload is removed — bare instantiation of the
abstract base is now a compile error.
- `ToolType` literal `'provider-defined'` → `'provider'`.
- `Toolset` now carries a `TOOLSET_SYMBOL` marker; added `isToolset()`
guard alongside `isFunctionTool` / `isProviderTool`. Replaced the one
remaining `instanceof Toolset` check in `agent_activity` for
cross-realm safety (consistent with how the other tool kinds are
detected).
- Plugin TODO comments in google / mistralai / openai / phonic updated
from "provider-defined tools" → "provider tools".
Tests, types, and changeset updated. All 312 LLM tests pass and the 31
publishable packages build clean.
Co-authored-by: u9g <jason.lernerman@livekit.io> Co-authored-by: rosetta-livekit-bot[bot] <282703043+rosetta-livekit-bot[bot]@users.noreply.github.com>
|
![devin-ai-integration[bot]](https://avatars.githubusercontent.com/in/811515?s=60&v=4){kind=small}
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.