fix(ipc): bound AgentSession close during job shutdown#1638
Open
rosetta-livekit-bot[bot] wants to merge 1 commit into
Open
fix(ipc): bound AgentSession close during job shutdown#1638rosetta-livekit-bot[bot] wants to merge 1 commit into
rosetta-livekit-bot[bot] wants to merge 1 commit into
Conversation
🦋 Changeset detectedLatest commit: 95a7a04 The changes in this PR will be included in the next version bump. This PR includes changesets to release 33 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
![devin-ai-integration[bot]](https://avatars.githubusercontent.com/in/811515?s=60&v=4){kind=small}
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
AgentSession.aclose()is called from_JobProc._run_job_taskduring job shutdown, with no timeout. If it blocks (stuckon_exit, hung provideraclose, an unresolved speech task, etc.), nothing in the supervisor recovers —_shutting_down_futhas no timeout and only resolves once the child sendsShuttingDown, which happens aftersession.aclose()returns. The result is that user-registeredJobContext.add_shutdown_callbackcallbacks silently never run.This wraps the
session.aclose()call withasyncio.wait_foragainst a hardcoded_SESSION_ACLOSE_TIMEOUT = 60.0sinjob_proc_lazy_main.py. On timeout we log and proceed, so the rest of the shutdown sequence (on_session_end,ShuttingDownack,room.disconnect, shutdown callbacks) still runs.Hardcoded for now as a defensive guardrail; can be converted to an option later if a tunable knob turns out to be needed.