Fix flaky IPC test EPIPE error #941
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: 4fab404 The changes in this PR will be included in the next version bump. This PR includes changesets to release 16 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
theomonnom
approved these changes
Jan 5, 2026
Shubhrakanti
reviewed
Jan 5, 2026
Comment on lines
+101
to
+103
| child.on('error', (err: NodeJS.ErrnoException) => { | ||
| if (err.code !== 'EPIPE') throw err; | ||
| }); |
Contributor
There was a problem hiding this comment.
what's the root case? Just curious.
Isn't it a real issue if we're writing to a closed stream?
Contributor
Author
There was a problem hiding this comment.
This is due to race condition. child.connected can still be true briefly after kill() while the pipe is already closed. The 20ms interval fires in that window results in EPIPE.
This is a test artifact, not a real app issue.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add error handler to suppress EPIPE race condition in
supervised_proc.test.ts