fix(silero): Persist RNN state between VAD inference calls #944
+7
−3
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes two bugs in the Silero VAD ONNX model wrapper that caused the RNN state to never be updated between inference calls:
Wrong output key: The ONNX model outputs the state as
stateN, notstate. The state was being read from the wrong key and never stored.Wrong context slice: Audio context was taken from the beginning of the input buffer instead of the end, breaking audio continuity between chunks.
Before
After
Mirrors fix from Python SDK: livekit/agents#4437