Remove second arg to init/LogSink#145
Closed
alan-george-lk wants to merge 1 commit into
Closed
Conversation
alan-george-lk
requested review from
stephen-derosa and
xianshijing-lk
as code owners
stephen-derosa
approved these changes
May 29, 2026
Collaborator
|
consumed by #143 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR introduces a breaking change to
livekit::initialize, removing the second argument, and removes theLogSinkenum entirely. This was not decided lightly and was a result of the extensive log forwarding investigation done in #133 and upcomingv1.0.0breaking changes anyways.LogSinkenum was not working as expectedkCallback, it would enable FFIcapture_logs, but no support existed in the FFI client to handle those events. So functionally,kCallbackwould silently disable all Rust logs (never would reach console out or callbacks of any kind)kCallbackwouldn't actually forward logs to the user lambda. That only works vialivekit::setLoggingCallback