Data Stream features and example #16
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
xianshijing-lk
changed the title
|
One important note: this implementation uses the deprecated FFI methods:
We have since added high-level methods which handle all the protocol-level details on the Rust side and handle error/edge cases that the Python implementation doesn't. Currently, these new methods have only been adopted in Unity. I don't think we need to upgrade this right away since it works now—just wanted to make a note of it. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR:
Implement the data stream and hook it up to the room
remove the publishTranscription and its relevant code
Implement the data stream example, which will send chat msgs and file to the other participants.
update the readme with the new example