Adding ability to specify per-trunk media timeouts#1534
Adding ability to specify per-trunk media timeouts#1534alexlivekit wants to merge 5 commits intomainfrom
Conversation
🦋 Changeset detectedLatest commit: a4f3941 The changes in this PR will be included in the next version bump. Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR 💥 An error occurred when fetching the changed packages and changesets in this PR |
|
@alexlivekit lets lend it after #1530 and move the media timeout into the new |
| if err := validateHeaderToAttributes(p.HeadersToAttributes); err != nil { | ||
| return err | ||
| } | ||
| timeout := MaxSIPMediaTimeout |
There was a problem hiding this comment.
After #1530 you could use new(MaxSIPMediaTimeout) as it updates Go to 1.26.
|
|
||
| // NEXT ID: 24 | ||
| // Per-call RTP media timeout; if unset, SIP service defaults apply. | ||
| google.protobuf.Duration media_timeout = 24; |
There was a problem hiding this comment.
Do we want to allow overriding the initial media timeout as well?
|
|
||
| // NEXT ID: 19 | ||
| // Max time a call can last without incoming RTP data received. If unset, defaults are used. | ||
| google.protobuf.Duration media_timeout = 19; |
There was a problem hiding this comment.
Lets move it to the dispatch rule level, similar to #1530. If you move this field to the SIPMediaConfig it will already be on the right level.
In general we should avoid adding new settings to trunks, as they might be gone after we implement the webhooks.
|
|
||
| // NEXT ID: 18 | ||
| // Max time a call can last without incoming RTP data received. If unset, defaults are used. | ||
| google.protobuf.Duration media_timeout = 18; |
There was a problem hiding this comment.
Same here, we could just leave it on the CreateSIPParticipant level and avoid using trunks.
3 participants
No description provided.