Skip to content

Allow specifying codecs for the SDP.#672

Merged
dennwc merged 2 commits intomainfrom
codecs
May 6, 2026
Merged

Allow specifying codecs for the SDP.#672
dennwc merged 2 commits intomainfrom
codecs

Conversation

@dennwc
Copy link
Copy Markdown
Contributor

@dennwc dennwc commented May 4, 2026

Allow specifying codec list for the SDP. All codecs supported by our media SDK can be enabled, even if they are not enabled by default.

Disabling codecs works by setting OnlyListedCodecs in the SIPMediaConfig and specifying the exact codec set. It will override any enable/disable flags we set.

For now there are no new supported codecs. The first planned additions are OPUS and AMR-WB which will follow shortly in separate PRs.

Requires livekit/protocol#1530

@dennwc dennwc self-assigned this May 4, 2026
@dennwc dennwc requested a review from a team as a code owner May 4, 2026 12:12
@dennwc dennwc force-pushed the codecs branch 5 times, most recently from 6a7135a to 2633619 Compare May 4, 2026 16:21
Copy link
Copy Markdown
Contributor

@hechen-eng hechen-eng left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Alt Text

@dennwc dennwc merged commit de926b0 into main May 6, 2026
6 checks passed
@dennwc dennwc deleted the codecs branch May 6, 2026 12:18
8thgencore pushed a commit to 8thgencore/livekit-sip that referenced this pull request May 6, 2026
* Allow specifying codecs for the SDP.

* Prevent data race when closing media conn during init.
8thgencore added a commit to 8thgencore/livekit-sip that referenced this pull request May 6, 2026
commit e42421a
Author: He Chen <he.chen@livekit.io>
Date:   Wed May 6 08:32:30 2026 -0700

    TEL-553: fix noisy srtp error log (livekit#670)

commit 358fdbf
Author: Denys Smirnov <dennwc@pm.me>
Date:   Wed May 6 14:18:53 2026 +0200

    Allow specifying codecs for the SDP. (livekit#672)

    * Allow specifying codecs for the SDP.

    * Prevent data race when closing media conn during init.

commit 4af99cf
Author: Alex <alex.migolin@livekit.io>
Date:   Tue May 5 19:53:49 2026 -0700

    Tagging outbound logs with sipCallID (livekit#674)

commit 20df3b5
Author: 8thgencore <axelmaker@ya.ru>
Date:   Wed May 6 18:22:00 2026 +0300

    feat: fix inbound

commit 16c5add
Author: 8thgencore <axelmaker@ya.ru>
Date:   Wed May 6 18:06:08 2026 +0300

    fix: novotel

commit 7926ca4
Author: 8thgencore <axelmaker@ya.ru>
Date:   Tue May 5 23:16:35 2026 +0300

    fix: outbound call for novotel

commit 3764416
Author: 8thgencore <axelmaker@ya.ru>
Date:   Tue May 5 22:43:08 2026 +0300

    fix: outbound call with register

commit 319c131
Merge: 3fb3ec9 75d7207
Author: 8thgencore <axelmaker@ya.ru>
Date:   Tue May 5 17:54:23 2026 +0300

    Merge remote-tracking branch 'origin/main' into feature/sip-register

commit 3fb3ec9
Author: blukky <d.shalkin@bag24.ru>
Date:   Tue May 5 10:30:11 2026 +0300

    refresh inbound trunk

commit b99560f
Author: 8thgencore <axelmaker@ya.ru>
Date:   Thu Apr 30 15:43:37 2026 +0300

    fix: change User-agent

commit 1e8d002
Author: 8thgencore <axelmaker@ya.ru>
Date:   Thu Apr 30 09:19:31 2026 +0300

    feat: fix inbound

commit 8d92c67
Author: 8thgencore <axelmaker@ya.ru>
Date:   Wed Apr 29 14:28:21 2026 +0300

    Handle terminated outbound invites as client errors

commit d3b999e
Author: 8thgencore <axelmaker@ya.ru>
Date:   Wed Apr 29 13:32:09 2026 +0300

    Use INVITE request URI for digest auth

commit 290af72
Merge: 8ca7c47 4c4c89f
Author: 8thgencore <axelmaker@ya.ru>
Date:   Wed Apr 29 11:09:47 2026 +0300

    Merge remote-tracking branch 'origin/main' into feature/sip-register

commit 8ca7c47
Author: 8thgencore <axelmaker@ya.ru>
Date:   Mon Apr 27 21:27:05 2026 +0300

    Retry outbound invite once on busy

commit 9b00928
Author: 8thgencore <axelmaker@ya.ru>
Date:   Mon Apr 27 20:30:38 2026 +0300

    Add sanitized SIP invite auth logging

commit 94c21e6
Merge: 7daccdb e5fc88f
Author: 8thgencore <axelmaker@ya.ru>
Date:   Mon Apr 27 15:59:07 2026 +0300

    Merge remote-tracking branch 'origin/main' into feature/sip-register

commit 7daccdb
Author: 8thgencore <axelmaker@ya.ru>
Date:   Mon Apr 27 15:28:54 2026 +0300

    feat: add inbound register

commit 98e646b
Author: 8thgencore <axelmaker@ya.ru>
Date:   Fri Apr 24 12:25:49 2026 +0300

    fix: add exclude register

commit bc3a84d
Author: 8thgencore <axelmaker@ya.ru>
Date:   Fri Apr 24 11:02:45 2026 +0300

    fix: add force register

commit 2775a5c
Author: 8thgencore <axelmaker@ya.ru>
Date:   Wed Apr 22 22:03:06 2026 +0300

    feat: add outbound SIP registration

commit c88c05f
Author: 8thgencore <axelmaker@ya.ru>
Date:   Wed Apr 22 14:15:42 2026 +0300

    fix: improve SIP registration handling

    fix: remove unused diagnostics

commit 45966c6
Author: 8thgencore <axelmaker@ya.ru>
Date:   Mon Apr 20 22:25:51 2026 +0300

    feat: add runtime and provider-aware SIP registration updates
8thgencore added a commit to 8thgencore/livekit-sip that referenced this pull request May 6, 2026
commit e42421a
Author: He Chen <he.chen@livekit.io>
Date:   Wed May 6 08:32:30 2026 -0700

    TEL-553: fix noisy srtp error log (livekit#670)

commit 358fdbf
Author: Denys Smirnov <dennwc@pm.me>
Date:   Wed May 6 14:18:53 2026 +0200

    Allow specifying codecs for the SDP. (livekit#672)

    * Allow specifying codecs for the SDP.

    * Prevent data race when closing media conn during init.

commit 4af99cf
Author: Alex <alex.migolin@livekit.io>
Date:   Tue May 5 19:53:49 2026 -0700

    Tagging outbound logs with sipCallID (livekit#674)

commit 20df3b5
Author: 8thgencore <axelmaker@ya.ru>
Date:   Wed May 6 18:22:00 2026 +0300

    feat: fix inbound

commit 16c5add
Author: 8thgencore <axelmaker@ya.ru>
Date:   Wed May 6 18:06:08 2026 +0300

    fix: novotel

commit 7926ca4
Author: 8thgencore <axelmaker@ya.ru>
Date:   Tue May 5 23:16:35 2026 +0300

    fix: outbound call for novotel

commit 3764416
Author: 8thgencore <axelmaker@ya.ru>
Date:   Tue May 5 22:43:08 2026 +0300

    fix: outbound call with register

commit 319c131
Merge: 3fb3ec9 75d7207
Author: 8thgencore <axelmaker@ya.ru>
Date:   Tue May 5 17:54:23 2026 +0300

    Merge remote-tracking branch 'origin/main' into feature/sip-register

commit 3fb3ec9
Author: blukky <d.shalkin@bag24.ru>
Date:   Tue May 5 10:30:11 2026 +0300

    refresh inbound trunk

commit b99560f
Author: 8thgencore <axelmaker@ya.ru>
Date:   Thu Apr 30 15:43:37 2026 +0300

    fix: change User-agent

commit 1e8d002
Author: 8thgencore <axelmaker@ya.ru>
Date:   Thu Apr 30 09:19:31 2026 +0300

    feat: fix inbound

commit 8d92c67
Author: 8thgencore <axelmaker@ya.ru>
Date:   Wed Apr 29 14:28:21 2026 +0300

    Handle terminated outbound invites as client errors

commit d3b999e
Author: 8thgencore <axelmaker@ya.ru>
Date:   Wed Apr 29 13:32:09 2026 +0300

    Use INVITE request URI for digest auth

commit 290af72
Merge: 8ca7c47 4c4c89f
Author: 8thgencore <axelmaker@ya.ru>
Date:   Wed Apr 29 11:09:47 2026 +0300

    Merge remote-tracking branch 'origin/main' into feature/sip-register

commit 8ca7c47
Author: 8thgencore <axelmaker@ya.ru>
Date:   Mon Apr 27 21:27:05 2026 +0300

    Retry outbound invite once on busy

commit 9b00928
Author: 8thgencore <axelmaker@ya.ru>
Date:   Mon Apr 27 20:30:38 2026 +0300

    Add sanitized SIP invite auth logging

commit 94c21e6
Merge: 7daccdb e5fc88f
Author: 8thgencore <axelmaker@ya.ru>
Date:   Mon Apr 27 15:59:07 2026 +0300

    Merge remote-tracking branch 'origin/main' into feature/sip-register

commit 7daccdb
Author: 8thgencore <axelmaker@ya.ru>
Date:   Mon Apr 27 15:28:54 2026 +0300

    feat: add inbound register

commit 98e646b
Author: 8thgencore <axelmaker@ya.ru>
Date:   Fri Apr 24 12:25:49 2026 +0300

    fix: add exclude register

commit bc3a84d
Author: 8thgencore <axelmaker@ya.ru>
Date:   Fri Apr 24 11:02:45 2026 +0300

    fix: add force register

commit 2775a5c
Author: 8thgencore <axelmaker@ya.ru>
Date:   Wed Apr 22 22:03:06 2026 +0300

    feat: add outbound SIP registration

commit c88c05f
Author: 8thgencore <axelmaker@ya.ru>
Date:   Wed Apr 22 14:15:42 2026 +0300

    fix: improve SIP registration handling

    fix: remove unused diagnostics

commit 45966c6
Author: 8thgencore <axelmaker@ya.ru>
Date:   Mon Apr 20 22:25:51 2026 +0300

    feat: add runtime and provider-aware SIP registration updates
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants