solution and test for problem #14#93
Open
rkalra247 wants to merge 1 commit intollipio:masterfrom
Open
Conversation
songz
requested changes
Jun 13, 2017
| for(let j = 0; j < array.length; j++){ | ||
| if(i === j){ | ||
| newArray.push(array[i][j]); | ||
| } |
| // Rahul Kalra | ||
| // Return an array of the diagnal values starting from 0,0 from a 2D array input(gauranteed to be square). | ||
|
|
||
| const solution = (array) =>{ |
Collaborator
There was a problem hiding this comment.
don't use array as a variable name. call it input
| @@ -0,0 +1,17 @@ | |||
| // Rahul Kalra | |||
| // Return an array of the diagnal values starting from 0,0 from a 2D array input(gauranteed to be square). | |||
Collaborator
There was a problem hiding this comment.
Please write proper comments, like here: https://github.com/llipio/algorithms/pull/75/files
yjlim5
requested changes
Jun 13, 2017
| @@ -0,0 +1,17 @@ | |||
| // Rahul Kalra | |||
| // Return an array of the diagnal values starting from 0,0 from a 2D array input(gauranteed to be square). | |||
Collaborator
There was a problem hiding this comment.
@rkalra247, please make sure there is no typo in comment, and add comments like this: https://github.com/llipio/algorithms/pull/55/files
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.