[Fix] Pin Pandas version & done future-proof type checking #45
+3
−3
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ype checks in Analyzer class
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request introduces a version constraint on the
pandasdependency and refines type checking for string columns in theset_layer_metricsfunction to improve compatibility and robustness.Dependency management:
pyproject.tomlto restrict thepandasdependency to versions>=2.2.0,<3.0.0to prevent compatibility issues with future major releases.Code robustness and pandas compatibility:
python/dftracer/analyzer/analyzer.py, replaced direct checks for"object"dtype withpd.api.types.is_string_dtypefor more accurate and future-proof string column detection in theset_layer_metricsfunction. This improves handling of string columns and aligns with best practices for pandas type checking.