Closed
Conversation
Member
|
@PardeepSinghBali - if you read through the thread at #110, you'll see discussion about #325 of LGD base which was identified as what caused it to be broken in the first place. And furthermore, when you look at that issue, it's suggested that this issue with Drupal core is the real culprit. Could you do some evaluations of those issues and see if resolving at that level would fix this issue as well as other places where unspecified form elements might be assigned conflicting IDs? It could be this PR is merely treating the symptom rather than addressing and fixing the root cause. |
Member
|
Thanks for this @PardeepSinghBali ! @Adnan-cds mentioned this in Merge Tuesday too. We'll convert to draft for now while we discuss and review. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this change?
with previous code , address drop down was working only for 1 dropdown in a form.
this fix will let user to add as many address field sets to add and each will have its own address dropdown populated w.r.t to address being searched
How to test
add Two or more different Address Field sets or one can duplicate the existing one.
search the address and see the addresses being populated in the respective dropdown
How can we measure success?
We can track how often the address dropdown is populated, especially the "No addresses found" or successful address options, and compare it to previous behavior before the fix.
Have we considered potential risks?
Images
Accessibility