Skip to content
Open
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 8 additions & 1 deletion internal/ui/app.go
Original file line number Diff line number Diff line change
Expand Up @@ -27,6 +27,7 @@ type styledLine struct {
text string
highlight bool
secondary bool
message *output.MessageEvent
}

type App struct {
Expand Down Expand Up @@ -141,7 +142,8 @@ func (a App) Update(msg tea.Msg) (tea.Model, tea.Cmd) {
a.spinner, _ = a.spinner.Stop()
return a, nil
case output.MessageEvent:
line := styledLine{text: components.RenderMessage(msg)}
msgCopy := msg
line := styledLine{text: components.RenderMessage(msg), message: &msgCopy}
if a.spinner.PendingStop() {
a.bufferedLines = append(a.bufferedLines, line)
} else {
Expand Down Expand Up @@ -314,6 +316,11 @@ func (a App) View() string {
}

for _, line := range a.lines {
if line.message != nil {
sb.WriteString(components.RenderWrappedMessage(*line.message, a.width))
sb.WriteString("\n")
continue
}
if line.highlight {
if isURL(line.text) {
wrapped := strings.Split(wrap.HardWrap(line.text, a.width), "\n")
Expand Down
27 changes: 27 additions & 0 deletions internal/ui/app_test.go
Original file line number Diff line number Diff line change
Expand Up @@ -8,8 +8,10 @@ import (
"time"

tea "github.com/charmbracelet/bubbletea"
"github.com/charmbracelet/lipgloss"
"github.com/charmbracelet/x/exp/teatest"
"github.com/localstack/lstk/internal/output"
"github.com/muesli/termenv"
)

func TestAppAddsFormattedLinesInOrder(t *testing.T) {
Expand Down Expand Up @@ -179,6 +181,31 @@ func TestAppMessageEventRendering(t *testing.T) {
}
}

func TestAppMessageEventWrapsOnVisibleWidth(t *testing.T) {
t.Parallel()

original := lipgloss.ColorProfile()
lipgloss.SetColorProfile(termenv.TrueColor)
t.Cleanup(func() { lipgloss.SetColorProfile(original) })

app := NewApp("dev", "", "", nil)
app.width = 40

model, _ := app.Update(output.MessageEvent{
Severity: output.SeverityNote,
Text: "LocalStack is still running in the background",
})
app = model.(App)

view := app.View()
if !strings.Contains(view, "background") {
t.Fatalf("expected wrapped message to include full word, got: %q", view)
}
if strings.Contains(view, "backg\nround") {
t.Fatalf("expected message to wrap at word boundary, got: %q", view)
}
}

func TestAppErrorEventStopsSpinner(t *testing.T) {
t.Parallel()

Expand Down
40 changes: 36 additions & 4 deletions internal/ui/components/message.go
Original file line number Diff line number Diff line change
@@ -1,20 +1,52 @@
package components

import (
"strings"

"github.com/localstack/lstk/internal/output"
"github.com/localstack/lstk/internal/ui/styles"
"github.com/localstack/lstk/internal/ui/wrap"
)

func RenderMessage(e output.MessageEvent) string {
return RenderWrappedMessage(e, 0)
}

func RenderWrappedMessage(e output.MessageEvent, width int) string {
prefixText, prefix := messagePrefix(e)
if prefixText == "" {
return styles.Message.Render(strings.Join(wrap.SoftWrap(e.Text, width), "\n"))
}

if width <= len([]rune(prefixText))+1 {
return prefix + " " + styles.Message.Render(e.Text)
}

availableWidth := width - len([]rune(prefixText)) - 1
lines := wrap.SoftWrap(e.Text, availableWidth)
if len(lines) == 0 {
return prefix
}

indent := strings.Repeat(" ", len([]rune(prefixText)))
rendered := make([]string, 0, len(lines))
rendered = append(rendered, prefix+" "+styles.Message.Render(lines[0]))
for _, line := range lines[1:] {
rendered = append(rendered, styles.Secondary.Render(indent)+" "+styles.Message.Render(line))
}
return strings.Join(rendered, "\n")
}

func messagePrefix(e output.MessageEvent) (string, string) {
prefix := styles.Secondary.Render("> ")
switch e.Severity {
case output.SeveritySuccess:
return prefix + styles.Success.Render("Success:") + " " + styles.Message.Render(e.Text)
return "> Success:", prefix + styles.Success.Render("Success:")
case output.SeverityNote:
return prefix + styles.Note.Render("Note:") + " " + styles.Message.Render(e.Text)
return "> Note:", prefix + styles.Note.Render("Note:")
case output.SeverityWarning:
return prefix + styles.Warning.Render("Warning:") + " " + styles.Message.Render(e.Text)
return "> Warning:", prefix + styles.Warning.Render("Warning:")
default:
return styles.Message.Render(e.Text)
return "", ""
}
}
Loading