Raise the default value of up to 512 MB#46
Merged
andsel merged 4 commits intologstash-plugins:mainfrom Sep 5, 2024
Merged
Conversation
jsvd
reviewed
Sep 5, 2024
jsvd
reviewed
Sep 5, 2024
jsvd
approved these changes
Sep 5, 2024
Member
jsvd
left a comment
jsvd
left a comment
There was a problem hiding this comment.
Added a rewording suggestion, otherwise LGTM
Co-authored-by: João Duarte <jsvd@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Release notes
Raise the default value of
decode_size_limit_bytesup to 512 MB.What does this PR do?
Updates the default value for setting
decode_size_limit_bytesto 512MB from 20MB, and print a deprecation log to inform the user the default value will be lowered in future version.Why is it important/What is the impact to the user?
Every parsing of incoming data should be limited, to avoid OOM. The original 20MB maybe is to low for some circumstances. To avoid generate noise to users that appropriately parses big json lines it's raised up to 512MB.
Checklist
[ ] I have made corresponding change to the default configuration files (and/or docker env variables)[ ] I have added tests that prove my fix is effective or that my feature worksAuthor's Checklist
How to test this PR locally
Related issues
Use cases
Screenshots
Logs