Skip to content

Use config.combined.yaml as the default collector config for combined layers#11

Merged
ralongit merged 1 commit intomainfrom
feat/combined-layer-default-config
Sep 30, 2025
Merged

Use config.combined.yaml as the default collector config for combined layers#11
ralongit merged 1 commit intomainfrom
feat/combined-layer-default-config

Conversation

@bardabun
Copy link
Copy Markdown

This PR adds a new production-ready configuration, collector/config.combined.yaml, and updates all combined layer build scripts to install it as the default /opt/collector-config/config.yaml.

This change avoids the build failure caused by the deprecated service.telemetry.metrics.address key in the old default config. It ensures that the combined layers work out-of-the-box without requiring users to set the OPENTELEMETRY_COLLECTOR_CONFIG_URI environment variable.

Changes

  • Added collector/config.combined.yaml.
  • Updated the following build scripts to prefer the new config as the default:
    • java/build-combined.sh
    • python/src/build-combined.sh
    • nodejs/packages/layer/build-combined.sh
    • ruby/build-combined.sh
    • go/build-combined.sh

Behavior

If collector/config.combined.yaml exists, it is copied to collector-config/config.yaml within the layer. Otherwise, the existing collector/config.yaml is used as a fallback.

Notes

  • The default config path used by the collector remains /opt/collector-config/config.yaml.
  • Users can still override this default by setting OPENTELEMETRY_COLLECTOR_CONFIG_URI if needed.

@bardabun bardabun requested a review from ralongit September 29, 2025 08:21
Copy link
Copy Markdown

@ralongit ralongit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💯

@ralongit ralongit merged commit c703c48 into main Sep 30, 2025
26 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants